Changeset 5827 for trunk/src/includes/search/functions.php

Timestamp:

07/14/2015 12:31:42 AM (11 years ago)

Author:

johnjamesjacoby

Message:

Abstraction: Use bbp_db(), bbp_rewrite() & friends, introduced in r5823 & r5826.

This commit improves the stability of bbPress in the WordPress environment by reducing global variable exposure. It also comes with minimal opcode improvements in some circumstances where $GLOBALS is preferred over defining via global statements.

Some additional surrounding cleanup directly related to functions & methods being altered is also being performed here.

Fixes #2786.

File:

• trunk/src/includes/search/functions.php (modified) (4 diffs)

trunk/src/includes/search/functions.php

@@ -16 +16 @@
  * Run the search query
  *
- * @since bbPress (r4579) 
+ * @since bbPress (r4579)
  *
  * @param mixed $new_args New arguments
@@ -26 +26 @@
 function bbp_search_query( $new_args = array() ) {
 
-    // Existing arguments 
+    // Existing arguments
     $query_args = bbp_get_search_query_args();
 
@@ -59 +59 @@
  *
  * @since bbPress (r4928)
+ *
  * @return If a redirect is not needed
  */
 function bbp_search_results_redirect() {
-    global $wp_rewrite;
-    
+
     // Bail if not a search request action
     if ( empty( $_GET['action'] ) || ( 'bbp-search-request' !== $_GET['action'] ) ) {
@@ -70 +70 @@
 
     // Bail if not using pretty permalinks
-    if ( ! $wp_rewrite->using_permalinks() ) {
+    if ( ! bbp_use_pretty_urls() ) {
         return;
     }