Changeset 5813

Timestamp:

07/12/2015 11:53:23 PM (10 years ago)

Author:

johnjamesjacoby

Message:

Users: Remove is_email() check from user query parsing.

This commit removes the ability to load a user profile via their email address. This feature (added in r2917) was a convenience mechanism to make finding a user within the forums with a known address easier, but times have changed and we now consider this to be a privacy concern by default.

Note: this will break backwards-compatibility for installations that may have used this unpublicized (and regrettably unwise) feature.

See #2828. Hat-tip netweb. For 2.6 (trunk)

File:

• trunk/src/includes/core/template-functions.php (modified) (2 diffs)

trunk/src/includes/core/template-functions.php

@@ -469 +469 @@
  *
  * @uses get_query_var() To get {@link WP_Query} query var
- * @uses is_email() To check if the string is an email
- * @uses get_user_by() To try to get the user by email and nicename
+ * @uses get_user_by() To try to get the user by nicename or id
  * @uses get_userdata() to get the user data
  * @uses current_user_can() To check if the current user can edit the user
@@ -512 +511 @@
         $the_user = false;
 
-        // If using pretty permalinks, use the email or slug
+        // If using pretty permalinks, always use slug
         if ( get_option( 'permalink_structure' ) ) {
-
-            // Email was passed
-            if ( is_email( $bbp_user ) ) {
-                $the_user = get_user_by( 'email', $bbp_user );
-
-            // Try nicename
-            } else {
-                $the_user = get_user_by( 'slug', $bbp_user );
-            }
-        }
-
-        // No user found by slug/email, so try the ID if it's numeric
-        if ( empty( $the_user ) && is_numeric( $bbp_user ) ) {
+            $the_user = get_user_by( 'slug', $bbp_user );
+
+        // If not using pretty permalinks, always use numeric ID
+        } elseif ( is_numeric( $bbp_user ) ) {
             $the_user = get_user_by( 'id', $bbp_user );
         }