Changeset 5739

Timestamp:

05/13/2015 12:35:49 AM (10 years ago)

Author:

johnjamesjacoby

Message:

Common: Improve type-casting return values in query functions.

Props thebrandonallen, netweb. See #2801.

File:

• trunk/src/includes/common/functions.php (modified) (4 diffs)

trunk/src/includes/common/functions.php

@@ -1530 +1530 @@
 
         $child_id = (int) $wpdb->get_var( $wpdb->prepare( "SELECT ID FROM {$wpdb->posts} WHERE post_parent = %d AND post_status IN ( {$post_status} ) AND post_type = '%s' ORDER BY ID DESC LIMIT 1;", $parent_id, $post_type ) );
+
         wp_cache_set( $cache_id, $child_id, 'bbpress_posts' );
+    } else {
+        $child_id = (int) $child_id;
     }
 
@@ -1578 +1581 @@
 
         $child_count = (int) $wpdb->get_var( $wpdb->prepare( "SELECT COUNT(ID) FROM {$wpdb->posts} WHERE post_parent = %d AND post_status IN ( {$post_status} ) AND post_type = '%s';", $parent_id, $post_type ) );
+
         wp_cache_set( $cache_id, $child_count, 'bbpress_posts' );
+    } else {
+        $child_count = (int) $child_count;
     }
 
@@ -1626 +1632 @@
 
         $child_ids = (array) $wpdb->get_col( $wpdb->prepare( "SELECT ID FROM {$wpdb->posts} WHERE post_parent = %d AND post_status IN ( {$post_status} ) AND post_type = '%s' ORDER BY ID DESC;", $parent_id, $post_type ) );
+
         wp_cache_set( $cache_id, $child_ids, 'bbpress_posts' );
+    } else {
+        $child_ids = (array) $child_ids;
     }
 
@@ -1690 +1699 @@
 
         $child_ids = (array) $wpdb->get_col( $wpdb->prepare( "SELECT ID FROM {$wpdb->posts} WHERE post_parent = %d AND post_status IN ( {$post_status} ) AND post_type = '%s' ORDER BY ID DESC;", $parent_id, $post_type ) );
+
         wp_cache_set( $cache_id, $child_ids, 'bbpress_posts' );
+    } else {
+        $child_ids = (array) $child_ids;
     }