Changeset 5737 for trunk/src/includes/replies/functions.php

Timestamp:

05/13/2015 12:34:42 AM (10 years ago)

Author:

johnjamesjacoby

Message:

Replies: Improve type-casting in reply functions. Also use newly created bbp_update_reply_to_id() function in bbp_update_reply_to().

Props thebrandonallen, netweb. See #2801.

File:

• trunk/src/includes/replies/functions.php (modified) (6 diffs)

trunk/src/includes/replies/functions.php

@@ -1035 +1035 @@
 
         // Get ancestors
-        $ancestors = (array) get_post_ancestors( $reply_id );
+        $ancestors = get_post_ancestors( $reply_id );
 
         // Loop through ancestors
@@ -1053 +1053 @@
 
     // Update the forum ID
-    bbp_update_forum_id( $reply_id, $forum_id );
-
-    return apply_filters( 'bbp_update_reply_forum_id', (int) $forum_id, $reply_id );
+    $forum_id = bbp_update_forum_id( $reply_id, $forum_id );
+
+    return (int) apply_filters( 'bbp_update_reply_forum_id', $forum_id, $reply_id );
 }
 
@@ -1102 +1102 @@
 
     // Update the topic ID
-    bbp_update_topic_id( $reply_id, $topic_id );
-
-    return apply_filters( 'bbp_update_reply_topic_id', (int) $topic_id, $reply_id );
+    $topic_id = bbp_update_topic_id( $reply_id, $topic_id );
+
+    return apply_filters( 'bbp_update_reply_topic_id', $topic_id, $reply_id );
 }
 
@@ -1130 +1130 @@
 
         // Update the reply to
-        if ( !empty( $reply_to ) ) {
-            update_post_meta( $reply_id, '_bbp_reply_to', $reply_to );
+        if ( ! empty( $reply_to ) ) {
+            $reply_to = bbp_update_reply_to_id( $reply_id, $reply_to );
 
         // Delete the reply to
@@ -1139 +1139 @@
     }
 
-    return (int) apply_filters( 'bbp_update_reply_to', (int) $reply_to, $reply_id );
+    return (int) apply_filters( 'bbp_update_reply_to', $reply_to, $reply_id );
 }
 
@@ -1188 +1188 @@
     }
 
-    return apply_filters( 'bbp_get_reply_ancestors', $ancestors, $reply_id );
+    return (array) apply_filters( 'bbp_get_reply_ancestors', $ancestors, $reply_id );
 }