Changeset 5734

Timestamp:

05/12/2015 10:44:46 PM (10 years ago)

Author:

johnjamesjacoby

Message:

Forums: Type-cast improvements to bbp_forum_query_last_reply_id().

Fixes bug where strict false comparison would cache cache condition to never occur.

Props thebrandonallen, netweb. See #2801.

File:

• trunk/src/includes/forums/functions.php (modified) (2 diffs)

trunk/src/includes/forums/functions.php

@@ -2002 +2002 @@
 
     $cache_id = 'bbp_get_forum_' . $forum_id . '_reply_id';
-    $reply_id = (int) wp_cache_get( $cache_id, 'bbpress_posts' );
+    $reply_id = wp_cache_get( $cache_id, 'bbpress_posts' );
 
     if ( false === $reply_id ) {
@@ -2013 +2013 @@
             $topic_ids = implode( ',', wp_parse_id_list( $topic_ids ) );
             $reply_id  = (int) $wpdb->get_var( $wpdb->prepare( "SELECT ID FROM {$wpdb->posts} WHERE post_parent IN ( {$topic_ids} ) AND post_status = '%s' AND post_type = '%s' ORDER BY ID DESC LIMIT 1;", bbp_get_public_status_id(), bbp_get_reply_post_type() ) );
-            wp_cache_set( $cache_id, $reply_id, 'bbpress_posts' ); // May be (int) 0
         } else {
-            wp_cache_set( $cache_id, '0', 'bbpress_posts' );
-        }
-    }
-
-    return (int) apply_filters( 'bbp_get_forum_last_reply_id', (int) $reply_id, $forum_id );
+            $reply_id = 0;
+        }
+
+        wp_cache_set( $cache_id, $reply_id, 'bbpress_posts' );
+    } else {
+        $reply_id = (int) $reply_id;
+    }
+
+    return (int) apply_filters( 'bbp_get_forum_last_reply_id', $reply_id, $forum_id );
 }