Changeset 5691 for trunk/src/includes/admin/admin.php

Timestamp:

04/20/2015 04:20:34 PM (11 years ago)

Author:

johnjamesjacoby

Message:

All: ensure all URLs are escaped (trunk) and cleanup some phpdoc

Also introduce bbp_dropdown class for dropdowns.

File:

• trunk/src/includes/admin/admin.php (modified) (2 diffs)

trunk/src/includes/admin/admin.php

@@ -517 +517 @@
         // Settings page link
         if ( current_user_can( 'bbp_settings_page' ) ) {
-            $new_links['settings'] = '<a href="' . add_query_arg( array( 'page' => 'bbpress'   ), admin_url( 'options-general.php' ) ) . '">' . esc_html__( 'Settings', 'bbpress' ) . '</a>';
+            $new_links['settings'] = '<a href="' . esc_url( add_query_arg( array( 'page' => 'bbpress'   ), admin_url( 'options-general.php' ) ) ) . '">' . esc_html__( 'Settings', 'bbpress' ) . '</a>';
         }
 
         // About page link
         if ( current_user_can( 'bbp_about_page' ) ) {
-            $new_links['about']    = '<a href="' . add_query_arg( array( 'page' => 'bbp-about' ), admin_url( 'index.php'           ) ) . '">' . esc_html__( 'About',    'bbpress' ) . '</a>';
+            $new_links['about']    = '<a href="' . esc_url( add_query_arg( array( 'page' => 'bbp-about' ), admin_url( 'index.php'           ) ) ) . '">' . esc_html__( 'About',    'bbpress' ) . '</a>';
         }
 
@@ -537 +537 @@
      */
     public function admin_bar_about_link( $wp_admin_bar ) {
-
         if ( is_user_logged_in() ) {
-
             $wp_admin_bar->add_menu( array(
                 'parent' => 'wp-logo',