Changeset 5669

Timestamp:

03/28/2015 07:10:00 AM (10 years ago)

Author:

netweb

Message:

Topics: Fix missing meta data during new closed topic creation

• In bbp_new_topic_handler() check if the post status is closed and close using bbp_close_topic()
• In bbp_close_topic() allow topics to be properly closed if _bbp_status is missing from topic meta

Props netweb. Fixes #2653

File:

• trunk/src/includes/topics/functions.php (modified) (7 diffs)

trunk/src/includes/topics/functions.php

@@ -104 +104 @@
  * @uses bbPress::errors::get_error_codes() To get the {@link WP_Error} errors
  * @uses wp_insert_post() To insert the topic
+ * @uses get_post_field() To get the post status
+ * @uses bbp_get_closed_status_id() To get the closed status id
+ * @uses bbp_close_topic() To close topics
+ * @uses bbp_get_trash_status_id() To get the trash status id
+ * @uses wp_trash_post() To trash topics
+ * @uses bbp_get_spam_status_id() To get the spam status id
+ * @uses add_post_meta() To add spam status meta to spam topics
  * @uses do_action() Calls 'bbp_new_topic' with the topic id, forum id,
  *                    anonymous data and reply author
@@ -341 +348 @@
     if ( ! empty( $topic_id ) && ! is_wp_error( $topic_id ) ) {
 
+        /** Close Check *******************************************************/
+
+        // If the topic is closed, close it properly
+        if ( ( get_post_field( 'post_status', $topic_id ) === bbp_get_closed_status_id() ) || ( $topic_data['post_status'] === bbp_get_closed_status_id() ) ) {
+
+            // Close the topic
+            bbp_close_topic( $topic_id );
+        }
+
         /** Trash Check *******************************************************/
 
         // If the forum is trash, or the topic_status is switched to
-        // trash, trash it properly
+        // trash, trash the topic properly
         if ( ( get_post_field( 'post_status', $forum_id ) === bbp_get_trash_status_id() ) || ( $topic_data['post_status'] === bbp_get_trash_status_id() ) ) {
 
-            // Trash the reply
+            // Trash the topic
             wp_trash_post( $topic_id );
 
@@ -356 +372 @@
         /** Spam Check ********************************************************/
 
-        // If reply or topic are spam, officially spam this reply
+        // If the topic is spam, officially spam this topic
         if ( $topic_data['post_status'] === bbp_get_spam_status_id() ) {
             add_post_meta( $topic_id, '_bbp_spam_meta_status', bbp_get_public_status_id() );
@@ -2746 +2762 @@
  * @param int $topic_id Topic id
  * @uses bbp_get_topic() To get the topic
+ * @uses get_post_meta() To get the topic status meta
+ * @uses bbp_get_closed_status_id() to get the closed status
+ * @uses bbp_get_public_status_id() to get the public status
  * @uses do_action() Calls 'bbp_close_topic' with the topic id
  * @uses add_post_meta() To add the previous status to a meta
@@ -2753 +2772 @@
  * @uses wp_update_post() To update the topic with the new status
  * @uses add_post_type_support() To restore topic revisions
- * @uses do_action() Calls 'bbp_opened_topic' with the topic id
+ * @uses do_action() Calls 'bbp_closed_topic' with the topic id
  * @return mixed False or {@link WP_Error} on failure, topic id on success
  */
@@ -2764 +2783 @@
     }
 
-    // Bail if already closed
-    if ( bbp_get_closed_status_id() === $topic->post_status ) {
+    // Get previous topic status meta
+    $topic_status = get_post_meta( $topic_id, '_bbp_status', true );
+
+    // Bail if already closed and topic status meta exists
+    if ( bbp_get_closed_status_id() === $topic->post_status && ! empty( $topic_status ) ) {
         return false;
     }
+
+    // Set status meta public
+    $topic_status = bbp_get_public_status_id();
 
     // Execute pre close code
@@ -2773 +2798 @@
 
     // Add pre close status
-    add_post_meta( $topic_id, '_bbp_status', $topic->post_status );
+    add_post_meta( $topic_id, '_bbp_status', $topic_status );
 
     // Set closed status