Changeset 5658 for trunk/src/includes/forums/functions.php

Timestamp:

03/24/2015 01:32:20 PM (11 years ago)

Author:

johnjamesjacoby

Message:

API: Introduce bbp_redirect()

• Wraps wp_safe_redirect() & exit() calls
• Prevents errors from potentially empty wp_get_referrer() results
• Replace wp_safe_redirect() usages with bbp_redirect()

Fixes #2778.

File:

• trunk/src/includes/forums/functions.php (modified) (6 diffs)

trunk/src/includes/forums/functions.php

@@ -104 +104 @@
  * @uses bbp_unstick_forum() To unstick the forum
  * @uses bbp_get_forum_permalink() To get the forum permalink
- * @uses wp_safe_redirect() To redirect to the forum link
+ * @uses bbp_redirect() To redirect to the forum link
  * @uses bbPress::errors::get_error_messages() To get the {@link WP_Error} error
  *                                              messages
@@ -332 +332 @@
 
         // Redirect back to new forum
-        wp_safe_redirect( $redirect_url );
-
-        // For good measure
-        exit();
+        bbp_redirect( $redirect_url );
 
     // Errors
@@ -373 +370 @@
  *                                 to another
  * @uses bbp_get_forum_permalink() To get the forum permalink
- * @uses wp_safe_redirect() To redirect to the forum link
+ * @uses bbp_redirect() To redirect to the forum link
  * @uses bbPress::errors::get_error_messages() To get the {@link WP_Error} error
  *                                              messages
@@ -587 +584 @@
 
         // Redirect back to new forum
-        wp_safe_redirect( $forum_url );
-
-        // For good measure
-        exit();
+        bbp_redirect( $forum_url );
 
     /** Errors ****************************************************************/
@@ -2127 +2121 @@
  * @uses current_user_can()
  * @uses bbp_get_forum_id()
- * @uses wp_safe_redirect()
+ * @uses bbp_redirect()
  * @uses bbp_get_forum_permalink()
  */
@@ -2133 +2127 @@
 
     // Bail if not editing a topic
-    if ( !bbp_is_forum_edit() ) {
+    if ( ! bbp_is_forum_edit() ) {
         return;
     }
 
     // User cannot edit topic, so redirect back to reply
-    if ( !current_user_can( 'edit_forum', bbp_get_forum_id() ) ) {
-        wp_safe_redirect( bbp_get_forum_permalink() );
-        exit();
+    if ( ! current_user_can( 'edit_forum', bbp_get_forum_id() ) ) {
+        bbp_redirect( bbp_get_forum_permalink() );
     }
 }