Changeset 5609

Timestamp:

01/30/2015 05:34:07 PM (10 years ago)

Author:

johnjamesjacoby

Message:

In bbp_current_author_ip() check $_SERVER['REMOTE_ADDR'] before attempting to parse it.

If it is empty (more likely for unit tests, but could be other oddities) we set it to '0.0.0.0' to do two things:

• Indicate to keymasters that something is amiss
• Allow bbp_current_author_ip() to proceed normally for the end-user

Fixes #2750.

File:

• trunk/src/includes/users/functions.php (modified) (1 diff)

trunk/src/includes/users/functions.php

@@ -144 +144 @@
  */
 function bbp_current_author_ip() {
-    $retval = preg_replace( '/[^0-9a-fA-F:., ]/', '', $_SERVER['REMOTE_ADDR'] );
-
-    return apply_filters( 'bbp_current_author_ip', $retval );
+
+    // Check for remote address
+    $remote_address = ! empty( $_SERVER['REMOTE_ADDR'] )
+        ? $_SERVER['REMOTE_ADDR']
+        : '0.0.0.0';
+
+    // Remove any unsavory bits
+    $retval = preg_replace( '/[^0-9a-fA-F:., ]/', '', $remote_address );
+
+    return apply_filters( 'bbp_current_author_ip', $retval, $remote_address );
 }