Changeset 5561 for trunk/src/includes/common/template.php

Timestamp:

11/10/2014 11:21:48 PM (10 years ago)

Author:

johnjamesjacoby

Message:

Deprecate tabindex functions and their usages. Props joedolson. Fixes #2714.

File:

• trunk/src/includes/common/template.php (modified) (6 diffs)

trunk/src/includes/common/template.php

@@ -1321 +1321 @@
  *
  * @since bbPress (r2810)
- *
+ * @deprecated since version 2.6
+ * @link https://bbpress.trac.wordpress.org/attachment/ticket/2714 Trac Ticket
  * @param int $auto_increment Optional. Default true. Set to false to prevent
  *                             increment
@@ -1337 +1338 @@
      *
      * @since bbPress (r2810)
-     *
+     * @deprecated bbPress (r5560)
+     * @link https://bbpress.trac.wordpress.org/attachment/ticket/2714 Trac Ticket
      * @uses apply_filters Allows return value to be filtered
      * @param int $auto_increment Optional. Default true. Set to false to
@@ -1389 +1391 @@
      *             {@link BBP_Walker_Dropdown}
      *  - select_id: ID of the select box. Defaults to 'bbp_forum_id'
-     *  - tab: Tabindex value. False or integer
+     *  - tab: Deprecated. Tabindex value. False or integer
      *  - options_only: Show only <options>? No <select>?
      *  - show_none: Boolean or String __( '(No Forum)', 'bbpress' )
@@ -1429 +1431 @@
             // Output-related
             'select_id'          => 'bbp_forum_id',
-            'tab'                => bbp_get_tab_index(),
+            'tab'                => false,
             'options_only'       => false,
             'show_none'          => false,
@@ -1774 +1776 @@
             'media_buttons'     => false,
             'textarea_rows'     => '12',
-            'tabindex'          => bbp_get_tab_index(),
+            'tabindex'          => false,
             'tabfocus_elements' => 'bbp_topic_title,bbp_topic_tags',
             'editor_class'      => 'bbp-the-content',
@@ -1836 +1838 @@
          * escaping the editable output, mucking up existing content.
          */
-        else : ?>
-
-            <textarea id="bbp_<?php echo esc_attr( $r['context'] ); ?>_content" class="<?php echo esc_attr( $r['editor_class'] ); ?>" name="bbp_<?php echo esc_attr( $r['context'] ); ?>_content" cols="60" rows="<?php echo esc_attr( $r['textarea_rows'] ); ?>" tabindex="<?php echo esc_attr( $r['tabindex'] ); ?>"><?php echo $post_content; ?></textarea>
+        else :
+
+            // Setup the tab index attribute
+            $tab = !empty( $r['tab'] ) ? ' tabindex="' . intval( $r['tab'] ) . '"' : ''; ?>
+
+            <textarea id="bbp_<?php echo esc_attr( $r['context'] ); ?>_content" class="<?php echo esc_attr( $r['editor_class'] ); ?>" name="bbp_<?php echo esc_attr( $r['context'] ); ?>_content" cols="60" rows="<?php echo esc_attr( $r['textarea_rows'] ); ?>" <?php echo $tab; ?>><?php echo $post_content; ?></textarea>
 
         <?php endif;