Changeset 5545

Timestamp:

10/10/2014 07:19:03 AM (10 years ago)

Author:

netweb

Message:

vBulletin 3 & 4: Fix reply parent forum id in vBulletin.php and vBulletin3.php importers

• Retrieves the replies topic ID and utilizes callback_topicid_to_forumid mini cache to convert the topic id to the new forum ID
• Eliminates an unnecessary SQL join improving import performance.

Location:

trunk/src/includes/admin/converters

Files:

• vBulletin.php (modified) (1 diff)
• vBulletin3.php (modified) (1 diff)

trunk/src/includes/admin/converters/vBulletin.php

@@ -351 +351 @@
 
         // Reply parent forum id (If no parent, then 0. Stored in postmeta)
-        // Note: We join the 'thread' table because 'post' table does not include forum id.
-        $this->field_map[] = array(
-            'from_tablename'  => 'thread',
-            'from_fieldname'  => 'forumid',
-            'join_tablename'  => 'post',
-            'join_type'       => 'INNER',
-            'join_expression' => 'USING (threadid) WHERE post.parentid != 0',
+        $this->field_map[] = array(
+            'from_tablename'  => 'post',
+            'from_fieldname'  => 'threadid',
+            'from_expression' => 'WHERE parentid != 0',
             'to_type'         => 'reply',
             'to_fieldname'    => '_bbp_forum_id',

trunk/src/includes/admin/converters/vBulletin3.php

@@ -351 +351 @@
 
         // Reply parent forum id (If no parent, then 0. Stored in postmeta)
-        // Note: We join the 'thread' table because 'post' table does not include forum id.
-        $this->field_map[] = array(
-            'from_tablename'  => 'thread',
-            'from_fieldname'  => 'forumid',
-            'join_tablename'  => 'post',
-            'join_type'       => 'INNER',
-            'join_expression' => 'USING (threadid) WHERE post.parentid != 0',
+        $this->field_map[] = array(
+            'from_tablename'  => 'post',
+            'from_fieldname'  => 'threadid',
+            'from_expression' => 'WHERE parentid != 0',
             'to_type'         => 'reply',
             'to_fieldname'    => '_bbp_forum_id',