Changeset 5537

Timestamp:

09/25/2014 05:59:42 AM (12 years ago)

Author:

netweb

Message:

Vanilla2 importer improvements:

• Don't import Vanilla 2's deleted topic or replies as both topic and reply content is deleted resulting in fragmented topic context
• Use callback_topicid_to_forumid to convert replies parent topic id to forum id eliminating a SQL join improving performance.

File:

• trunk/src/includes/admin/converters/Vanilla.php (modified) (3 diffs)

trunk/src/includes/admin/converters/Vanilla.php

@@ -153 +153 @@
 
         // Old topic id (Stored in postmeta)
-        $this->field_map[] = array(
-            'from_tablename' => 'Discussion',
-            'from_fieldname' => 'DiscussionID',
-            'to_type'        => 'topic',
-            'to_fieldname'   => '_bbp_old_topic_id'
+        // Don't import Vanilla 2's deleted topics
+        $this->field_map[] = array(
+            'from_tablename'  => 'Discussion',
+            'from_fieldname'  => 'DiscussionID',
+            'from_expression' => 'WHERE Format != "Deleted"',
+            'to_type'         => 'topic',
+            'to_fieldname'    => '_bbp_old_topic_id'
         );
 
@@ -322 +324 @@
 
         // Old reply id (Stored in postmeta)
+        // Don't import Vanilla 2's deleted replies
         $this->field_map[] = array(
             'from_tablename'  => 'Comment',
             'from_fieldname'  => 'CommentID',
+            'from_expression' => 'WHERE Format != "Deleted"',
             'to_type'         => 'reply',
             'to_fieldname'    => '_bbp_old_reply_id'
@@ -340 +344 @@
         // Reply parent forum id (If no parent, then 0. Stored in postmeta)
         $this->field_map[] = array(
-            'from_tablename'  => 'Discussion',
-            'from_fieldname'  => 'CategoryID',
-            'join_tablename'  => 'Comment',
-            'join_type'       => 'INNER',
-            'join_expression' => 'USING (DiscussionID)',
+            'from_tablename'  => 'Comment',
+            'from_fieldname'  => 'DiscussionID',
             'to_type'         => 'reply',
             'to_fieldname'    => '_bbp_forum_id',
-            'callback_method' => 'callback_forumid'
+            'callback_method' => 'callback_topicid_to_forumid'
         );