Skip to:
Content

bbPress.org


Ignore:
Timestamp:
09/11/2014 03:49:07 PM (7 years ago)
Author:
johnjamesjacoby
Message:

Simplify topic & reply author role markup arguments, with backpat support. Props netweb. Fixes #2557.

File:
1 edited

Legend:

Unmodified
Added
Removed
  • trunk/src/includes/topics/template.php

    r5504 r5513  
    17161716        $r = bbp_parse_args( $args, array(
    17171717            'topic_id' => 0,
    1718             'class'    => 'bbp-author-role',
    1719             'before'   => '',
    1720             'after'    => ''
     1718            'class'    => false,
     1719            'before'   => '<div class="bbp-author-role">',
     1720            'after'    => '</div>'
    17211721        ), 'get_topic_author_role' );
    17221722
    17231723        $topic_id    = bbp_get_topic_id( $r['topic_id'] );
    17241724        $role        = bbp_get_user_display_role( bbp_get_topic_author_id( $topic_id ) );
    1725         $author_role = sprintf( '%1$s<div class="%2$s">%3$s</div>%4$s', $r['before'], $r['class'], $role, $r['after'] );
     1725
     1726        // Backwards compatibilty with old 'class' argument
     1727        if ( ! empty( $r['class'] ) ) {
     1728            $author_role = sprintf( '%1$s<div class="%2$s">%3$s</div>%4$s', $r['before'], $r['class'], $role, $r['after'] );
     1729
     1730        // Simpler before & after arguments
     1731        // https://bbpress.trac.wordpress.org/ticket/2557
     1732        } else {
     1733            $author_role = $r['before'] . $role . $r['after'];
     1734        }
    17261735
    17271736        return apply_filters( 'bbp_get_topic_author_role', $author_role, $r );
Note: See TracChangeset for help on using the changeset viewer.