Skip to:
Content

bbPress.org


Ignore:
Timestamp:
09/11/2014 03:49:07 PM (7 years ago)
Author:
johnjamesjacoby
Message:

Simplify topic & reply author role markup arguments, with backpat support. Props netweb. Fixes #2557.

File:
1 edited

Legend:

Unmodified
Added
Removed
  • trunk/src/includes/replies/template.php

    r5507 r5513  
    14341434        $r = bbp_parse_args( $args, array(
    14351435            'reply_id' => 0,
    1436             'class'    => 'bbp-author-role',
    1437             'before'   => '',
    1438             'after'    => ''
     1436            'class'    => false,
     1437            'before'   => '<div class="bbp-author-role">',
     1438            'after'    => '</div>'
    14391439        ), 'get_reply_author_role' );
    14401440
    14411441        $reply_id    = bbp_get_reply_id( $r['reply_id'] );
    14421442        $role        = bbp_get_user_display_role( bbp_get_reply_author_id( $reply_id ) );
    1443         $author_role = sprintf( '%1$s<div class="%2$s">%3$s</div>%4$s', $r['before'], esc_attr( $r['class'] ), esc_html( $role ), $r['after'] );
     1443
     1444        // Backwards compatibilty with old 'class' argument
     1445        if ( ! empty( $r['class'] ) ) {
     1446            $author_role = sprintf( '%1$s<div class="%2$s">%3$s</div>%4$s', $r['before'], esc_attr( $r['class'] ), esc_html( $role ), $r['after'] );
     1447
     1448        // Simpler before & after arguments
     1449        // https://bbpress.trac.wordpress.org/ticket/2557
     1450        } else {
     1451            $author_role = $r['before'] . $role . $r['after'];
     1452        }
    14441453
    14451454        return apply_filters( 'bbp_get_reply_author_role', $author_role, $r );
Note: See TracChangeset for help on using the changeset viewer.