Changeset 5510 for trunk/src/includes/admin/metaboxes.php

Timestamp:

09/11/2014 03:11:17 PM (10 years ago)

Author:

johnjamesjacoby

Message:

Only allow direct modification of reply forum meta when there is a mismatch with the topic forum.

This prevents moderators and keymasters from creating mismatches and leaves the tool available only for repairs (usually after a migration from a different platform.) Fixes #2270.

File:

• trunk/src/includes/admin/metaboxes.php (modified) (2 diffs)

trunk/src/includes/admin/metaboxes.php

@@ -473 +473 @@
     $reply_topic_id = bbp_get_reply_topic_id( $post_id );
     $reply_forum_id = bbp_get_reply_forum_id( $post_id );
-
+    $topic_forum_id = bbp_get_topic_forum_id( $reply_topic_id );
 
     /** Status ****************************************************************/
@@ -491 +491 @@
     /** Forum *****************************************************************/
 
-    // Allow individual manipulation of reply forum
-    if ( current_user_can( 'edit_others_replies' ) || current_user_can( 'moderate' ) ) : ?>
+    // Only allow individual manipulation of reply forum if there is a mismatch
+    if ( ( $reply_forum_id !== $topic_forum_id ) && ( current_user_can( 'edit_others_replies' ) || current_user_can( 'moderate' ) ) ) : ?>
 
         <p>