Changeset 5489

Timestamp:

09/10/2014 10:52:46 PM (10 years ago)

Author:

johnjamesjacoby

Message:

In bbp_merge_topic_handler() delete last and count metas, and update the reply position after call to wp_update_post(). Fixes bug where merging two topics with odd timestamps could result in orphaned or incorrect meta data and hierarchy positioning. Props netweb. Fixes #2528.

File:

• trunk/src/includes/topics/functions.php (modified) (4 diffs)

trunk/src/includes/topics/functions.php

@@ -1221 +1221 @@
 
     // Check if the destination topic is older than the source topic
-    if ( strtotime( $destination_topic->post_date ) < strtotime( $source_topic->post_date ) ) {
+    if ( strtotime( $source_topic->post_date ) < strtotime( $destination_topic->post_date ) ) {
 
         // Set destination topic post_date to 1 second before source topic
@@ -1300 +1300 @@
     // Sticky
     bbp_unstick_topic( $source_topic->ID );
+
+    // Delete source topic's last & count meta data
+    delete_post_meta( $source_topic->ID, '_bbp_last_reply_id'      );
+    delete_post_meta( $source_topic->ID, '_bbp_last_active_id'     );
+    delete_post_meta( $source_topic->ID, '_bbp_last_active_time'   );
+    delete_post_meta( $source_topic->ID, '_bbp_voice_count'        );
+    delete_post_meta( $source_topic->ID, '_bbp_reply_count'        );
+    delete_post_meta( $source_topic->ID, '_bbp_reply_count_hidden' );
 
     // Get the replies of the source topic
@@ -1326 +1334 @@
                 'post_type'   => bbp_get_reply_post_type(),
                 'post_parent' => $destination_topic->ID,
-                'menu_order'  => bbp_get_reply_position_raw( $reply->ID, $destination_topic->ID ),
                 'guid'        => ''
             ) );
@@ -1334 +1341 @@
             bbp_update_reply_forum_id( $reply->ID, bbp_get_topic_forum_id( $destination_topic->ID ) );
 
-            // Adjust reply to values
-            $reply_to = bbp_get_reply_to( $reply->ID );
-            if ( empty( $reply_to ) ) {
-                bbp_update_reply_to( $reply->ID, $source_topic->ID );
-            }
+            // Update the reply position
+            bbp_update_reply_position( $reply->ID );
 
             // Do additional actions per merged reply