Changeset 5443

Timestamp:

07/11/2014 09:57:54 PM (11 years ago)

Author:

johnjamesjacoby

Message:

Breathing room for ! usages in Topics component.

Location:

trunk/src/includes/topics

Files:

• capabilities.php (modified) (4 diffs)
• functions.php (modified) (92 diffs)
• template.php (modified) (52 diffs)

trunk/src/includes/topics/capabilities.php

@@ -79 +79 @@
                 // Get the post
                 $_post = get_post( $args[0] );
-                if ( !empty( $_post ) ) {
+                if ( ! empty( $_post ) ) {
 
                     // Get caps for post type object
@@ -134 +134 @@
             // Get the post
             $_post = get_post( $args[0] );
-            if ( !empty( $_post ) ) {
+            if ( ! empty( $_post ) ) {
 
                 // Get caps for post type object
@@ -145 +145 @@
 
                 // User is author so allow edit if not in admin
-                } elseif ( !is_admin() && ( (int) $user_id === (int) $_post->post_author ) ) {
+                } elseif ( ! is_admin() && ( (int) $user_id === (int) $_post->post_author ) ) {
                     $caps[] = $post_type->cap->edit_posts;
 
@@ -162 +162 @@
             // Get the post
             $_post = get_post( $args[0] );
-            if ( !empty( $_post ) ) {
+            if ( ! empty( $_post ) ) {
 
                 // Get caps for post type object

trunk/src/includes/topics/functions.php

@@ -70 +70 @@
     // Update the forum
     $forum_id = bbp_get_topic_forum_id( $topic_id );
-    if ( !empty( $forum_id ) ) {
+    if ( ! empty( $forum_id ) ) {
         bbp_update_forum( array( 'forum_id' => $forum_id ) );
     }
@@ -141 +141 @@
 
         // Anonymous data checks out, so set cookies, etc...
-        if ( !empty( $anonymous_data ) && is_array( $anonymous_data ) ) {
+        if ( ! empty( $anonymous_data ) && is_array( $anonymous_data ) ) {
             bbp_set_current_anonymous_user_data( $anonymous_data );
         }
@@ -149 +149 @@
 
         // User cannot create topics
-        if ( !current_user_can( 'publish_topics' ) ) {
+        if ( ! current_user_can( 'publish_topics' ) ) {
             bbp_add_error( 'bbp_topic_permissions', __( '<strong>ERROR</strong>: You do not have permission to create new topics.', 'bbpress' ) );
             return;
@@ -159 +159 @@
 
     // Remove kses filters from title and content for capable users and if the nonce is verified
-    if ( current_user_can( 'unfiltered_html' ) && !empty( $_POST['_bbp_unfiltered_html_topic'] ) && wp_create_nonce( 'bbp-unfiltered-html-topic_new' ) === $_POST['_bbp_unfiltered_html_topic'] ) {
+    if ( current_user_can( 'unfiltered_html' ) && ! empty( $_POST['_bbp_unfiltered_html_topic'] ) && wp_create_nonce( 'bbp-unfiltered-html-topic_new' ) === $_POST['_bbp_unfiltered_html_topic'] ) {
         remove_filter( 'bbp_new_topic_pre_title',   'wp_filter_kses'      );
         remove_filter( 'bbp_new_topic_pre_content', 'bbp_encode_bad',  10 );
@@ -167 +167 @@
     /** Topic Title ***********************************************************/
 
-    if ( !empty( $_POST['bbp_topic_title'] ) ) {
+    if ( ! empty( $_POST['bbp_topic_title'] ) ) {
         $topic_title = esc_attr( strip_tags( $_POST['bbp_topic_title'] ) );
     }
@@ -181 +181 @@
     /** Topic Content *********************************************************/
 
-    if ( !empty( $_POST['bbp_topic_content'] ) ) {
+    if ( ! empty( $_POST['bbp_topic_content'] ) ) {
         $topic_content = $_POST['bbp_topic_content'];
     }
@@ -232 +232 @@
 
     // Forum exists
-    if ( !empty( $forum_id ) ) {
+    if ( ! empty( $forum_id ) ) {
 
         // Forum is a category
@@ -242 +242 @@
 
             // Forum is closed and user cannot access
-            if ( bbp_is_forum_closed( $forum_id ) && !current_user_can( 'edit_forum', $forum_id ) ) {
+            if ( bbp_is_forum_closed( $forum_id ) && ! current_user_can( 'edit_forum', $forum_id ) ) {
                 bbp_add_error( 'bbp_new_topic_forum_closed', __( '<strong>ERROR</strong>: This forum has been closed to new topics.', 'bbpress' ) );
             }
@@ -248 +248 @@
             // Forum is private and user cannot access
             if ( bbp_is_forum_private( $forum_id ) ) {
-                if ( !current_user_can( 'read_private_forums' ) ) {
+                if ( ! current_user_can( 'read_private_forums' ) ) {
                     bbp_add_error( 'bbp_new_topic_forum_private', __( '<strong>ERROR</strong>: This forum is private and you do not have the capability to read or create new topics in it.', 'bbpress' ) );
                 }
@@ -254 +254 @@
             // Forum is hidden and user cannot access
             } elseif ( bbp_is_forum_hidden( $forum_id ) ) {
-                if ( !current_user_can( 'read_hidden_forums' ) ) {
+                if ( ! current_user_can( 'read_hidden_forums' ) ) {
                     bbp_add_error( 'bbp_new_topic_forum_hidden', __( '<strong>ERROR</strong>: This forum is hidden and you do not have the capability to read or create new topics in it.', 'bbpress' ) );
                 }
@@ -263 +263 @@
     /** Topic Flooding ********************************************************/
 
-    if ( !bbp_check_for_flood( $anonymous_data, $topic_author ) ) {
+    if ( ! bbp_check_for_flood( $anonymous_data, $topic_author ) ) {
         bbp_add_error( 'bbp_topic_flood', __( '<strong>ERROR</strong>: Slow down; you move too fast.', 'bbpress' ) );
     }
@@ -269 +269 @@
     /** Topic Duplicate *******************************************************/
 
-    if ( !bbp_check_for_duplicate( array( 'post_type' => bbp_get_topic_post_type(), 'post_author' => $topic_author, 'post_content' => $topic_content, 'anonymous_data' => $anonymous_data ) ) ) {
+    if ( ! bbp_check_for_duplicate( array( 'post_type' => bbp_get_topic_post_type(), 'post_author' => $topic_author, 'post_content' => $topic_content, 'anonymous_data' => $anonymous_data ) ) ) {
         bbp_add_error( 'bbp_topic_duplicate', __( '<strong>ERROR</strong>: Duplicate topic detected; it looks as though you&#8217;ve already said that!', 'bbpress' ) );
     }
@@ -275 +275 @@
     /** Topic Blacklist *******************************************************/
 
-    if ( !bbp_check_for_blacklist( $anonymous_data, $topic_author, $topic_title, $topic_content ) ) {
+    if ( ! bbp_check_for_blacklist( $anonymous_data, $topic_author, $topic_title, $topic_content ) ) {
         bbp_add_error( 'bbp_topic_blacklist', __( '<strong>ERROR</strong>: Your topic cannot be created at this time.', 'bbpress' ) );
     }
@@ -282 +282 @@
 
     // Maybe put into moderation
-    if ( !bbp_check_for_moderation( $anonymous_data, $topic_author, $topic_title, $topic_content ) ) {
+    if ( ! bbp_check_for_moderation( $anonymous_data, $topic_author, $topic_title, $topic_content ) ) {
         $topic_status = bbp_get_pending_status_id();
 
     // Check a whitelist of possible topic status ID's
-    } elseif ( !empty( $_POST['bbp_topic_status'] ) && in_array( $_POST['bbp_topic_status'], array_keys( bbp_get_topic_statuses() ) ) ) {
+    } elseif ( ! empty( $_POST['bbp_topic_status'] ) && in_array( $_POST['bbp_topic_status'], array_keys( bbp_get_topic_statuses() ) ) ) {
         $topic_status = $_POST['bbp_topic_status'];
 
@@ -296 +296 @@
     /** Topic Tags ************************************************************/
 
-    if ( bbp_allow_topic_tags() && !empty( $_POST['bbp_topic_tags'] ) ) {
+    if ( bbp_allow_topic_tags() && ! empty( $_POST['bbp_topic_tags'] ) ) {
 
         // Escape tag input
@@ -339 +339 @@
     /** No Errors *************************************************************/
 
-    if ( !empty( $topic_id ) && !is_wp_error( $topic_id ) ) {
+    if ( ! empty( $topic_id ) && ! is_wp_error( $topic_id ) ) {
 
         /** Trash Check *******************************************************/
@@ -371 +371 @@
 
         // Sticky check after 'bbp_new_topic' action so forum ID meta is set
-        if ( !empty( $_POST['bbp_stick_topic'] ) && in_array( $_POST['bbp_stick_topic'], array( 'stick', 'super', 'unstick' ) ) ) {
+        if ( ! empty( $_POST['bbp_stick_topic'] ) && in_array( $_POST['bbp_stick_topic'], array( 'stick', 'super', 'unstick' ) ) ) {
 
             // What's the caps?
@@ -410 +410 @@
 
         // Add view all?
-        if ( bbp_get_view_all() || !empty( $view_all ) ) {
+        if ( bbp_get_view_all() || ! empty( $view_all ) ) {
 
             // User can moderate, so redirect to topic with view all set
@@ -512 +512 @@
 
             // User cannot edit this topic
-            if ( !current_user_can( 'edit_topic', $topic_id ) ) {
+            if ( ! current_user_can( 'edit_topic', $topic_id ) ) {
                 bbp_add_error( 'bbp_edit_topic_permissions', __( '<strong>ERROR</strong>: You do not have permission to edit that topic.', 'bbpress' ) );
             }
@@ -534 +534 @@
 
     // Remove kses filters from title and content for capable users and if the nonce is verified
-    if ( current_user_can( 'unfiltered_html' ) && !empty( $_POST['_bbp_unfiltered_html_topic'] ) && ( wp_create_nonce( 'bbp-unfiltered-html-topic_' . $topic_id ) === $_POST['_bbp_unfiltered_html_topic'] ) ) {
+    if ( current_user_can( 'unfiltered_html' ) && ! empty( $_POST['_bbp_unfiltered_html_topic'] ) && ( wp_create_nonce( 'bbp-unfiltered-html-topic_' . $topic_id ) === $_POST['_bbp_unfiltered_html_topic'] ) ) {
         remove_filter( 'bbp_edit_topic_pre_title',   'wp_filter_kses'      );
         remove_filter( 'bbp_edit_topic_pre_content', 'bbp_encode_bad',  10 );
@@ -555 +555 @@
 
     // Forum exists
-    if ( !empty( $forum_id ) && ( $forum_id !== $current_forum_id ) ) {
+    if ( ! empty( $forum_id ) && ( $forum_id !== $current_forum_id ) ) {
 
         // Forum is a category
@@ -565 +565 @@
 
             // Forum is closed and user cannot access
-            if ( bbp_is_forum_closed( $forum_id ) && !current_user_can( 'edit_forum', $forum_id ) ) {
+            if ( bbp_is_forum_closed( $forum_id ) && ! current_user_can( 'edit_forum', $forum_id ) ) {
                 bbp_add_error( 'bbp_edit_topic_forum_closed', __( '<strong>ERROR</strong>: This forum has been closed to new topics.', 'bbpress' ) );
             }
@@ -571 +571 @@
             // Forum is private and user cannot access
             if ( bbp_is_forum_private( $forum_id ) ) {
-                if ( !current_user_can( 'read_private_forums' ) ) {
+                if ( ! current_user_can( 'read_private_forums' ) ) {
                     bbp_add_error( 'bbp_edit_topic_forum_private', __( '<strong>ERROR</strong>: This forum is private and you do not have the capability to read or create new topics in it.', 'bbpress' ) );
                 }
@@ -577 +577 @@
             // Forum is hidden and user cannot access
             } elseif ( bbp_is_forum_hidden( $forum_id ) ) {
-                if ( !current_user_can( 'read_hidden_forums' ) ) {
+                if ( ! current_user_can( 'read_hidden_forums' ) ) {
                     bbp_add_error( 'bbp_edit_topic_forum_hidden', __( '<strong>ERROR</strong>: This forum is hidden and you do not have the capability to read or create new topics in it.', 'bbpress' ) );
                 }
@@ -586 +586 @@
     /** Topic Title ***********************************************************/
 
-    if ( !empty( $_POST['bbp_topic_title'] ) ) {
+    if ( ! empty( $_POST['bbp_topic_title'] ) ) {
         $topic_title = esc_attr( strip_tags( $_POST['bbp_topic_title'] ) );
     }
@@ -600 +600 @@
     /** Topic Content *********************************************************/
 
-    if ( !empty( $_POST['bbp_topic_content'] ) ) {
+    if ( ! empty( $_POST['bbp_topic_content'] ) ) {
         $topic_content = $_POST['bbp_topic_content'];
     }
@@ -614 +614 @@
     /** Topic Blacklist *******************************************************/
 
-    if ( !bbp_check_for_blacklist( $anonymous_data, $topic_author, $topic_title, $topic_content ) ) {
+    if ( ! bbp_check_for_blacklist( $anonymous_data, $topic_author, $topic_title, $topic_content ) ) {
         bbp_add_error( 'bbp_topic_blacklist', __( '<strong>ERROR</strong>: Your topic cannot be edited at this time.', 'bbpress' ) );
     }
@@ -621 +621 @@
 
     // Maybe put into moderation
-    if ( !bbp_check_for_moderation( $anonymous_data, $topic_author, $topic_title, $topic_content ) ) {
+    if ( ! bbp_check_for_moderation( $anonymous_data, $topic_author, $topic_title, $topic_content ) ) {
 
         // Set post status to pending if public or closed
@@ -629 +629 @@
 
     // Check a whitelist of possible topic status ID's
-    } elseif ( !empty( $_POST['bbp_topic_status'] ) && in_array( $_POST['bbp_topic_status'], array_keys( bbp_get_topic_statuses() ) ) ) {
+    } elseif ( ! empty( $_POST['bbp_topic_status'] ) && in_array( $_POST['bbp_topic_status'], array_keys( bbp_get_topic_statuses() ) ) ) {
         $topic_status = $_POST['bbp_topic_status'];
 
@@ -703 +703 @@
     /** No Errors *************************************************************/
 
-    if ( !empty( $topic_id ) && !is_wp_error( $topic_id ) ) {
+    if ( ! empty( $topic_id ) && ! is_wp_error( $topic_id ) ) {
 
         // Update counts, etc...
@@ -711 +711 @@
 
         // Revision Reason
-        if ( !empty( $_POST['bbp_topic_edit_reason'] ) ) {
+        if ( ! empty( $_POST['bbp_topic_edit_reason'] ) ) {
             $topic_edit_reason = esc_attr( strip_tags( $_POST['bbp_topic_edit_reason'] ) );
         }
 
         // Update revision log
-        if ( !empty( $_POST['bbp_log_topic_edit'] ) && ( "1" === $_POST['bbp_log_topic_edit'] ) )  {
+        if ( ! empty( $_POST['bbp_log_topic_edit'] ) && ( "1" === $_POST['bbp_log_topic_edit'] ) )  {
             $revision_id = wp_save_post_revision( $topic_id );
             if ( ! empty( $revision_id ) ) {
@@ -739 +739 @@
         /** Stickies **********************************************************/
 
-        if ( !empty( $_POST['bbp_stick_topic'] ) && in_array( $_POST['bbp_stick_topic'], array_keys( bbp_get_topic_types() ) ) ) {
+        if ( ! empty( $_POST['bbp_stick_topic'] ) && in_array( $_POST['bbp_stick_topic'], array_keys( bbp_get_topic_types() ) ) ) {
 
             // What's the caps?
@@ -782 +782 @@
 
         // Add view all?
-        if ( !empty( $view_all ) ) {
+        if ( ! empty( $view_all ) ) {
             $topic_url = bbp_add_view_all( $topic_url );
         }
@@ -859 +859 @@
     // It expects anonymous_data to be sanitized.
     // Check bbp_filter_anonymous_post_data() for sanitization.
-    if ( !empty( $anonymous_data ) && is_array( $anonymous_data ) ) {
+    if ( ! empty( $anonymous_data ) && is_array( $anonymous_data ) ) {
 
         // Parse arguments against default values
@@ -879 +879 @@
 
     } else {
-        if ( empty( $is_edit ) && !current_user_can( 'throttle' ) ) {
+        if ( empty( $is_edit ) && ! current_user_can( 'throttle' ) ) {
             bbp_update_user_last_posted( $author_id );
         }
@@ -885 +885 @@
 
     // Handle Subscription Checkbox
-    if ( bbp_is_subscriptions_active() && !empty( $author_id ) ) {
+    if ( bbp_is_subscriptions_active() && ! empty( $author_id ) ) {
         $subscribed = bbp_is_user_subscribed( $author_id, $topic_id );
-        $subscheck  = ( !empty( $_POST['bbp_topic_subscription'] ) && ( 'bbp_subscribe' === $_POST['bbp_topic_subscription'] ) ) ? true : false;
+        $subscheck  = ( ! empty( $_POST['bbp_topic_subscription'] ) && ( 'bbp_subscribe' === $_POST['bbp_topic_subscription'] ) ) ? true : false;
 
         // Subscribed and unsubscribing
@@ -952 +952 @@
 
     // Topic was passed
-    if ( !empty( $topic_id ) ) {
+    if ( ! empty( $topic_id ) ) {
 
         // Get the forum ID if none was passed
@@ -976 +976 @@
 
     // Loop through ancestors
-    if ( !empty( $ancestors ) ) {
+    if ( ! empty( $ancestors ) ) {
         foreach ( $ancestors as $ancestor ) {
 
@@ -1033 +1033 @@
 
     // Only proceed if stickies are found
-    if ( !empty( $old_stickies ) ) {
+    if ( ! empty( $old_stickies ) ) {
 
         // Define local variables
@@ -1078 +1078 @@
 
     // Loop through ancestors and update them
-    if ( !empty( $old_forum_ancestors ) ) {
+    if ( ! empty( $old_forum_ancestors ) ) {
         foreach ( $old_forum_ancestors as $ancestor ) {
             if ( bbp_is_forum( $ancestor ) ) {
@@ -1091 +1091 @@
 
     // Make sure we're not walking twice
-    if ( !in_array( $new_forum_id, $old_forum_ancestors ) ) {
+    if ( ! in_array( $new_forum_id, $old_forum_ancestors ) ) {
 
         // Get topic ancestors
@@ -1100 +1100 @@
 
         // Loop through ancestors and update them
-        if ( !empty( $new_forum_ancestors ) ) {
+        if ( ! empty( $new_forum_ancestors ) ) {
             foreach ( $new_forum_ancestors as $ancestor ) {
                 if ( bbp_is_forum( $ancestor ) ) {
@@ -1184 +1184 @@
 
     // Cannot edit source topic
-    if ( !current_user_can( 'edit_topic', $source_topic->ID ) ) {
+    if ( ! current_user_can( 'edit_topic', $source_topic->ID ) ) {
         bbp_add_error( 'bbp_merge_topic_source_permission', __( '<strong>ERROR</strong>: You do not have the permissions to edit the source topic.', 'bbpress' ) );
         return;
@@ -1204 +1204 @@
 
     // Cannot edit destination topic
-    if ( !current_user_can( 'edit_topic', $destination_topic->ID ) ) {
+    if ( ! current_user_can( 'edit_topic', $destination_topic->ID ) ) {
         bbp_add_error( 'bbp_merge_topic_destination_permission', __( '<strong>ERROR</strong>: You do not have the permissions to edit the destination topic.', 'bbpress' ) );
     }
@@ -1240 +1240 @@
 
     // Remove the topic from everybody's subscriptions
-    if ( !empty( $subscribers ) ) {
+    if ( ! empty( $subscribers ) ) {
 
         // Loop through each user
@@ -1246 +1246 @@
 
             // Shift the subscriber if told to
-            if ( !empty( $_POST['bbp_topic_subscribers'] ) && ( "1" === $_POST['bbp_topic_subscribers'] ) && bbp_is_subscriptions_active() ) {
+            if ( ! empty( $_POST['bbp_topic_subscribers'] ) && ( "1" === $_POST['bbp_topic_subscribers'] ) && bbp_is_subscriptions_active() ) {
                 bbp_add_user_subscription( $subscriber, $destination_topic->ID );
             }
@@ -1261 +1261 @@
 
     // Remove the topic from everybody's favorites
-    if ( !empty( $favoriters ) ) {
+    if ( ! empty( $favoriters ) ) {
 
         // Loop through each user
@@ -1267 +1267 @@
 
             // Shift the favoriter if told to
-            if ( !empty( $_POST['bbp_topic_favoriters'] ) && "1" === $_POST['bbp_topic_favoriters'] ) {
+            if ( ! empty( $_POST['bbp_topic_favoriters'] ) && "1" === $_POST['bbp_topic_favoriters'] ) {
                 bbp_add_user_favorite( $favoriter, $destination_topic->ID );
             }
@@ -1282 +1282 @@
 
     // Tags to possibly merge
-    if ( !empty( $source_topic_tags ) && !is_wp_error( $source_topic_tags ) ) {
+    if ( ! empty( $source_topic_tags ) && ! is_wp_error( $source_topic_tags ) ) {
 
         // Shift the tags if told to
-        if ( !empty( $_POST['bbp_topic_tags'] ) && ( "1" === $_POST['bbp_topic_tags'] ) ) {
+        if ( ! empty( $_POST['bbp_topic_tags'] ) && ( "1" === $_POST['bbp_topic_tags'] ) ) {
             wp_set_post_terms( $destination_topic->ID, $source_topic_tags, bbp_get_topic_tag_tax_id(), true );
         }
@@ -1312 +1312 @@
     array_unshift( $replies, $source_topic );
 
-    if ( !empty( $replies ) ) {
+    if ( ! empty( $replies ) ) {
 
         /** Merge Replies *****************************************************/
@@ -1494 +1494 @@
 
     // Use cannot edit topic
-    if ( !current_user_can( 'edit_topic', $source_topic->ID ) ) {
+    if ( ! current_user_can( 'edit_topic', $source_topic->ID ) ) {
         bbp_add_error( 'bbp_split_topic_source_permission', __( '<strong>ERROR</strong>: You do not have the permissions to edit the source topic.', 'bbpress' ) );
     }
 
     // How to Split
-    if ( !empty( $_POST['bbp_topic_split_option'] ) ) {
+    if ( ! empty( $_POST['bbp_topic_split_option'] ) ) {
         $split_option = (string) trim( $_POST['bbp_topic_split_option'] );
     }
 
     // Invalid split option
-    if ( empty( $split_option ) || !in_array( $split_option, array( 'existing', 'reply' ) ) ) {
+    if ( empty( $split_option ) || ! in_array( $split_option, array( 'existing', 'reply' ) ) ) {
         bbp_add_error( 'bbp_split_topic_option', __( '<strong>ERROR</strong>: You need to choose a valid split option.', 'bbpress' ) );
 
@@ -1532 +1532 @@
 
                 // User cannot edit the destination topic
-                if ( !current_user_can( 'edit_topic', $destination_topic->ID ) ) {
+                if ( ! current_user_can( 'edit_topic', $destination_topic->ID ) ) {
                     bbp_add_error( 'bbp_split_topic_destination_permission', __( '<strong>ERROR</strong>: You do not have the permissions to edit the destination topic!', 'bbpress' ) );
                 }
@@ -1546 +1546 @@
 
                     // Use the new title that was passed
-                    if ( !empty( $_POST['bbp_topic_split_destination_title'] ) ) {
+                    if ( ! empty( $_POST['bbp_topic_split_destination_title'] ) ) {
                         $destination_topic_title = esc_attr( strip_tags( $_POST['bbp_topic_split_destination_title'] ) );
 
@@ -1612 +1612 @@
 
     // Copy the subscribers
-    if ( !empty( $_POST['bbp_topic_subscribers'] ) && "1" === $_POST['bbp_topic_subscribers'] && bbp_is_subscriptions_active() ) {
+    if ( ! empty( $_POST['bbp_topic_subscribers'] ) && "1" === $_POST['bbp_topic_subscribers'] && bbp_is_subscriptions_active() ) {
 
         // Get the subscribers
         $subscribers = bbp_get_topic_subscribers( $source_topic->ID );
 
-        if ( !empty( $subscribers ) ) {
+        if ( ! empty( $subscribers ) ) {
 
             // Add subscribers to new topic
@@ -1629 +1629 @@
 
     // Copy the favoriters if told to
-    if ( !empty( $_POST['bbp_topic_favoriters'] ) && ( "1" === $_POST['bbp_topic_favoriters'] ) ) {
+    if ( ! empty( $_POST['bbp_topic_favoriters'] ) && ( "1" === $_POST['bbp_topic_favoriters'] ) ) {
 
         // Get the favoriters
         $favoriters = bbp_get_topic_favoriters( $source_topic->ID );
 
-        if ( !empty( $favoriters ) ) {
+        if ( ! empty( $favoriters ) ) {
 
             // Add the favoriters to new topic
@@ -1646 +1646 @@
 
     // Copy the tags if told to
-    if ( !empty( $_POST['bbp_topic_tags'] ) && ( "1" === $_POST['bbp_topic_tags'] ) ) {
+    if ( ! empty( $_POST['bbp_topic_tags'] ) && ( "1" === $_POST['bbp_topic_tags'] ) ) {
 
         // Get the source topic tags
         $source_topic_tags = wp_get_post_terms( $source_topic->ID, bbp_get_topic_tag_tax_id(), array( 'fields' => 'names' ) );
 
-        if ( !empty( $source_topic_tags ) ) {
+        if ( ! empty( $source_topic_tags ) ) {
             wp_set_post_terms( $destination_topic->ID, $source_topic_tags, bbp_get_topic_tag_tax_id(), true );
         }
@@ -1663 +1663 @@
 
     // Make sure there are replies to loop through
-    if ( !empty( $replies ) && !is_wp_error( $replies ) ) {
+    if ( ! empty( $replies ) && ! is_wp_error( $replies ) ) {
 
         // Calculate starting point for reply positions
@@ -1709 +1709 @@
 
             // Not a reply to a reply that moved over
-            if ( !in_array( $reply_to, $reply_ids ) ) {
+            if ( ! in_array( $reply_to, $reply_ids ) ) {
                 bbp_update_reply_to( $reply->ID, 0 );
             }
@@ -1839 +1839 @@
 
     // Bail if actions aren't meant for this function
-    if ( !in_array( $action, $possible_actions ) ) {
+    if ( ! in_array( $action, $possible_actions ) ) {
         return;
     }
@@ -1866 +1866 @@
 
             // Can user edit topic tags?
-            if ( !current_user_can( 'edit_topic_tags' ) ) {
+            if ( ! current_user_can( 'edit_topic_tags' ) ) {
                 bbp_add_error( 'bbp_manage_topic_tag_update_permissions', __( '<strong>ERROR</strong>: You do not have the permissions to edit the topic tags.', 'bbpress' ) );
                 return;
@@ -1878 +1878 @@
 
             // Attempt to update the tag
-            $slug        = !empty( $_POST['tag-slug']        ) ? $_POST['tag-slug']        : '';
-            $description = !empty( $_POST['tag-description'] ) ? $_POST['tag-description'] : '';
+            $slug        = ! empty( $_POST['tag-slug']        ) ? $_POST['tag-slug']        : '';
+            $description = ! empty( $_POST['tag-description'] ) ? $_POST['tag-description'] : '';
             $tag         = wp_update_term( $tag_id, bbp_get_topic_tag_tax_id(), array( 'name' => $name, 'slug' => $slug, 'description' => $description ) );
 
@@ -1906 +1906 @@
 
             // Can user edit topic tags?
-            if ( !current_user_can( 'edit_topic_tags' ) ) {
+            if ( ! current_user_can( 'edit_topic_tags' ) ) {
                 bbp_add_error( 'bbp_manage_topic_tag_merge_permissions', __( '<strong>ERROR</strong>: You do not have the permissions to edit the topic tags.', 'bbpress' ) );
                 return;
@@ -1964 +1964 @@
 
             // Can user delete topic tags?
-            if ( !current_user_can( 'delete_topic_tags' ) ) {
+            if ( ! current_user_can( 'delete_topic_tags' ) ) {
                 bbp_add_error( 'bbp_manage_topic_tag_delete_permissions', __( '<strong>ERROR</strong>: You do not have the permissions to delete the topic tags.', 'bbpress' ) );
                 return;
@@ -1990 +1990 @@
 
     // Redirect back
-    $redirect = ( !empty( $redirect ) && !is_wp_error( $redirect ) ) ? $redirect : home_url();
+    $redirect = ( ! empty( $redirect ) && ! is_wp_error( $redirect ) ) ? $redirect : home_url();
     wp_safe_redirect( $redirect );
 
@@ -2046 +2046 @@
 function bbp_get_stickies( $forum_id = 0 ) {
     $stickies = empty( $forum_id ) ? bbp_get_super_stickies() : get_post_meta( $forum_id, '_bbp_sticky_topics', true );
-    $stickies = ( empty( $stickies ) || !is_array( $stickies ) ) ? array() : $stickies;
+    $stickies = ( empty( $stickies ) || ! is_array( $stickies ) ) ? array() : $stickies;
 
     return apply_filters( 'bbp_get_stickies', $stickies, (int) $forum_id );
@@ -2062 +2062 @@
 function bbp_get_super_stickies() {
     $stickies = get_option( '_bbp_super_sticky_topics', array() );
-    $stickies = ( empty( $stickies ) || !is_array( $stickies ) ) ? array() : $stickies;
+    $stickies = ( empty( $stickies ) || ! is_array( $stickies ) ) ? array() : $stickies;
 
     return apply_filters( 'bbp_get_super_stickies', $stickies );
@@ -2117 +2117 @@
 
     // Bail if actions aren't meant for this function
-    if ( !in_array( $action, $possible_actions ) ) {
+    if ( ! in_array( $action, $possible_actions ) ) {
         return;
     }
@@ -2135 +2135 @@
 
     // What is the user doing here?
-    if ( !current_user_can( 'edit_topic', $topic->ID ) || ( 'bbp_toggle_topic_trash' === $action && !current_user_can( 'delete_topic', $topic->ID ) ) ) {
+    if ( ! current_user_can( 'edit_topic', $topic->ID ) || ( 'bbp_toggle_topic_trash' === $action && ! current_user_can( 'delete_topic', $topic->ID ) ) ) {
         bbp_add_error( 'bbp_toggle_topic_permission', __( '<strong>ERROR:</strong> You do not have the permission to do that.', 'bbpress' ) );
         return;
@@ -2158 +2158 @@
 
             $is_sticky = bbp_is_topic_sticky( $topic_id );
-            $is_super  = false === $is_sticky && !empty( $_GET['super'] ) && ( "1" === $_GET['super'] ) ? true : false;
+            $is_super  = false === $is_sticky && ! empty( $_GET['super'] ) && ( "1" === $_GET['super'] ) ? true : false;
             $success   = true  === $is_sticky ? bbp_unstick_topic( $topic_id ) : bbp_stick_topic( $topic_id, $is_super );
             $failure   = true  === $is_sticky ? __( '<strong>ERROR</strong>: There was a problem unsticking the topic.', 'bbpress' ) : __( '<strong>ERROR</strong>: There was a problem sticking the topic.', 'bbpress' );
@@ -2178 +2178 @@
         case 'bbp_toggle_topic_trash' :
 
-            $sub_action = !empty( $_GET['sub_action'] ) && in_array( $_GET['sub_action'], array( 'trash', 'untrash', 'delete' ) ) ? $_GET['sub_action'] : false;
+            $sub_action = ! empty( $_GET['sub_action'] ) && in_array( $_GET['sub_action'], array( 'trash', 'untrash', 'delete' ) ) ? $_GET['sub_action'] : false;
 
             if ( empty( $sub_action ) ) {
@@ -2218 +2218 @@
 
     // No errors
-    if ( false !== $success && !is_wp_error( $success ) ) {
+    if ( false !== $success && ! is_wp_error( $success ) ) {
 
         // Redirect back to the topic's forum
@@ -2267 +2267 @@
 
     // Users exist
-    if ( !empty( $users ) ) {
+    if ( ! empty( $users ) ) {
 
         // Loop through users
@@ -2292 +2292 @@
 
     // Subscriptions are not active
-    if ( !bbp_is_subscriptions_active() ) {
+    if ( ! bbp_is_subscriptions_active() ) {
         return;
     }
@@ -2307 +2307 @@
 
     // Users exist
-    if ( !empty( $users ) ) {
+    if ( ! empty( $users ) ) {
 
         // Loop through users
@@ -2536 +2536 @@
 
     // Adjust last_id's based on last_reply post_type
-    if ( empty( $active_id ) || !bbp_is_reply( $active_id ) ) {
+    if ( empty( $active_id ) || ! bbp_is_reply( $active_id ) ) {
         $active_id = $topic_id;
     }
@@ -2576 +2576 @@
 
     // Update only if published
-    if ( !empty( $new_time ) ) {
+    if ( ! empty( $new_time ) ) {
         update_post_meta( $topic_id, '_bbp_last_active_time', $new_time );
     }
@@ -2617 +2617 @@
 
     // Adjust last_id's based on last_reply post_type
-    if ( empty( $reply_id ) || !bbp_is_reply( $reply_id ) ) {
+    if ( empty( $reply_id ) || ! bbp_is_reply( $reply_id ) ) {
         $reply_id = 0;
     }
@@ -2933 +2933 @@
     ) );
 
-    if ( !empty( $replies->posts ) ) {
+    if ( ! empty( $replies->posts ) ) {
 
         // Prevent debug notices
@@ -2976 +2976 @@
 
     // Topic has tags
-    if ( !empty( $terms ) ) {
+    if ( ! empty( $terms ) ) {
 
         // Loop through and collect term names
@@ -2984 +2984 @@
 
         // Topic terms have slugs
-        if ( !empty( $term_names ) ) {
+        if ( ! empty( $term_names ) ) {
 
             // Add the original post status as post meta for future restoration
@@ -3070 +3070 @@
 
     // There are replies to untrash
-    if ( !empty( $pre_spammed_replies ) ) {
+    if ( ! empty( $pre_spammed_replies ) ) {
 
         // Maybe reverse the trashed replies array
@@ -3105 +3105 @@
 
     // Delete pre-spam topic tag meta
-    if ( !empty( $terms ) ) {
+    if ( ! empty( $terms ) ) {
         delete_post_meta( $topic_id, '_bbp_spam_topic_tags' );
     }
@@ -3149 +3149 @@
     do_action( 'bbp_stick_topic', $topic_id, $super );
 
-    if ( !is_array( $stickies ) ) {
+    if ( ! is_array( $stickies ) ) {
         $stickies   = array( $topic_id );
     } else {
@@ -3167 +3167 @@
     // Reset keys
     $stickies = array_values( $stickies );
-    $success  = !empty( $super ) ? update_option( '_bbp_super_sticky_topics', $stickies ) : update_post_meta( $forum_id, '_bbp_sticky_topics', $stickies );
+    $success  = ! empty( $super ) ? update_option( '_bbp_super_sticky_topics', $stickies ) : update_post_meta( $forum_id, '_bbp_sticky_topics', $stickies );
 
     do_action( 'bbp_stuck_topic', $topic_id, $super, $success );
@@ -3203 +3203 @@
     if ( empty( $stickies ) ) {
         $success = true;
-    } elseif ( !in_array( $topic_id, $stickies ) ) {
+    } elseif ( ! in_array( $topic_id, $stickies ) ) {
         $success = true;
     } elseif ( false === $offset ) {
@@ -3210 +3210 @@
         array_splice( $stickies, $offset, 1 );
         if ( empty( $stickies ) ) {
-            $success = !empty( $super ) ? delete_option( '_bbp_super_sticky_topics'            ) : delete_post_meta( $forum_id, '_bbp_sticky_topics'            );
+            $success = ! empty( $super ) ? delete_option( '_bbp_super_sticky_topics'            ) : delete_post_meta( $forum_id, '_bbp_sticky_topics'            );
         } else {
-            $success = !empty( $super ) ? update_option( '_bbp_super_sticky_topics', $stickies ) : update_post_meta( $forum_id, '_bbp_sticky_topics', $stickies );
+            $success = ! empty( $super ) ? update_option( '_bbp_super_sticky_topics', $stickies ) : update_post_meta( $forum_id, '_bbp_sticky_topics', $stickies );
         }
     }
@@ -3338 +3338 @@
     ) );
 
-    if ( !empty( $replies->posts ) ) {
+    if ( ! empty( $replies->posts ) ) {
 
         // Prevent debug notices
@@ -3397 +3397 @@
 
     // There are replies to untrash
-    if ( !empty( $pre_trashed_replies ) ) {
+    if ( ! empty( $pre_trashed_replies ) ) {
 
         // Maybe reverse the trashed replies array
@@ -3535 +3535 @@
         $terms[] = $term->name;
     }
-    $terms = !empty( $terms ) ? implode( $sep, $terms ) : '';
+    $terms = ! empty( $terms ) ? implode( $sep, $terms ) : '';
 
     return apply_filters( 'bbp_get_topic_tags', $terms, $topic_id );
@@ -3590 +3590 @@
 
     // User cannot access this forum
-    if ( bbp_is_single_forum() && !bbp_user_can_view_forum( array( 'forum_id' => bbp_get_forum_id() ) ) ) {
+    if ( bbp_is_single_forum() && ! bbp_user_can_view_forum( array( 'forum_id' => bbp_get_forum_id() ) ) ) {
         return;
     }
@@ -3681 +3681 @@
 
     // User cannot edit topic, so redirect back to topic
-    if ( !current_user_can( 'edit_topic', bbp_get_topic_id() ) ) {
+    if ( ! current_user_can( 'edit_topic', bbp_get_topic_id() ) ) {
         wp_safe_redirect( bbp_get_topic_permalink() );
         exit();
@@ -3706 +3706 @@
 
     // Bail if current user cannot edit topic tags
-    if ( !current_user_can( 'edit_topic_tags', bbp_get_topic_tag_id() ) ) {
+    if ( ! current_user_can( 'edit_topic_tags', bbp_get_topic_tag_id() ) ) {
         wp_safe_redirect( bbp_get_topic_tag_link() );
         exit();

trunk/src/includes/topics/template.php

@@ -145 +145 @@
 
     // Other defaults
-    $default_topic_search  = !empty( $_REQUEST['ts'] ) ? $_REQUEST['ts'] : false;
+    $default_topic_search  = ! empty( $_REQUEST['ts'] ) ? $_REQUEST['ts'] : false;
     $default_show_stickies = (bool) ( bbp_is_single_forum() || bbp_is_topic_archive() ) && ( false === $default_topic_search );
     $default_post_parent   = bbp_is_single_forum() ? bbp_get_forum_id() : 'any';
@@ -211 +211 @@
 
     // Limited the number of pages shown
-    if ( !empty( $r['max_num_pages'] ) ) {
+    if ( ! empty( $r['max_num_pages'] ) ) {
         $bbp->topic_query->max_num_pages = $r['max_num_pages'];
     }
@@ -218 +218 @@
 
     // Put sticky posts at the top of the posts array
-    if ( !empty( $r['show_stickies'] ) && $r['paged'] <= 1 ) {
+    if ( ! empty( $r['show_stickies'] ) && $r['paged'] <= 1 ) {
 
         // Get super stickies and stickies in this forum
@@ -224 +224 @@
 
         // Get stickies for current forum
-        if ( !empty( $r['post_parent'] ) ) {
+        if ( ! empty( $r['post_parent'] ) ) {
             $stickies = array_merge( $stickies, bbp_get_stickies( $r['post_parent'] ) );
         }
@@ -232 +232 @@
 
         // We have stickies
-        if ( is_array( $stickies ) && !empty( $stickies ) ) {
+        if ( is_array( $stickies ) && ! empty( $stickies ) ) {
 
             // Start the offset at -1 so first sticky is at correct 0 offset
@@ -273 +273 @@
 
             // If any posts have been excluded specifically, Ignore those that are sticky.
-            if ( !empty( $stickies ) && !empty( $r['post__not_in'] ) ) {
+            if ( ! empty( $stickies ) && ! empty( $r['post__not_in'] ) ) {
                 $stickies = array_diff( $stickies, $r['post__not_in'] );
             }
 
             // Fetch sticky posts that weren't in the query results
-            if ( !empty( $stickies ) ) {
+            if ( ! empty( $stickies ) ) {
 
                 // Query to use in get_posts to get sticky posts
@@ -311 +311 @@
                 // Get all stickies
                 $sticky_posts = get_posts( $sticky_query );
-                if ( !empty( $sticky_posts ) ) {
+                if ( ! empty( $sticky_posts ) ) {
 
                     // Get a count of the visible stickies
@@ -343 +343 @@
 
         // Limit the number of topics shown based on maximum allowed pages
-        if ( ( !empty( $r['max_num_pages'] ) ) && $bbp->topic_query->found_posts > $bbp->topic_query->max_num_pages * $bbp->topic_query->post_count ) {
+        if ( ( ! empty( $r['max_num_pages'] ) ) && $bbp->topic_query->found_posts > $bbp->topic_query->max_num_pages * $bbp->topic_query->post_count ) {
             $bbp->topic_query->found_posts = $bbp->topic_query->max_num_pages * $bbp->topic_query->post_count;
         }
@@ -490 +490 @@
 
         // Easy empty checking
-        if ( !empty( $topic_id ) && is_numeric( $topic_id ) ) {
+        if ( ! empty( $topic_id ) && is_numeric( $topic_id ) ) {
             $bbp_topic_id = $topic_id;
 
         // Currently inside a topic loop
-        } elseif ( !empty( $bbp->topic_query->in_the_loop ) && isset( $bbp->topic_query->post->ID ) ) {
+        } elseif ( ! empty( $bbp->topic_query->in_the_loop ) && isset( $bbp->topic_query->post->ID ) ) {
             $bbp_topic_id = $bbp->topic_query->post->ID;
 
         // Currently inside a search loop
-        } elseif ( !empty( $bbp->search_query->in_the_loop ) && isset( $bbp->search_query->post->ID ) && bbp_is_topic( $bbp->search_query->post->ID ) ) {
+        } elseif ( ! empty( $bbp->search_query->in_the_loop ) && isset( $bbp->search_query->post->ID ) && bbp_is_topic( $bbp->search_query->post->ID ) ) {
             $bbp_topic_id = $bbp->search_query->post->ID;
 
         // Currently viewing/editing a topic, likely alone
-        } elseif ( ( bbp_is_single_topic() || bbp_is_topic_edit() ) && !empty( $bbp->current_topic_id ) ) {
+        } elseif ( ( bbp_is_single_topic() || bbp_is_topic_edit() ) && ! empty( $bbp->current_topic_id ) ) {
             $bbp_topic_id = $bbp->current_topic_id;
 
@@ -600 +600 @@
 
         // Use the redirect address
-        if ( !empty( $redirect_to ) ) {
+        if ( ! empty( $redirect_to ) ) {
             $topic_permalink = esc_url_raw( $redirect_to );
 
@@ -674 +674 @@
             // Set root text to page title
             $page = bbp_get_page_by_path( bbp_get_topic_archive_slug() );
-            if ( !empty( $page ) ) {
+            if ( ! empty( $page ) ) {
                 $title = get_the_title( $page->ID );
 
@@ -770 +770 @@
         }
 
-        if ( !empty( $length ) && ( $excerpt_length > $length ) ) {
+        if ( ! empty( $length ) && ( $excerpt_length > $length ) ) {
             $excerpt  = substr( $excerpt, 0, $length - 1 );
             $excerpt .= '&hellip;';
@@ -808 +808 @@
 
         // 4 days, 4 hours ago
-        if ( !empty( $humanize ) ) {
-            $gmt_s  = !empty( $gmt ) ? 'U' : 'G';
+        if ( ! empty( $humanize ) ) {
+            $gmt_s  = ! empty( $gmt ) ? 'U' : 'G';
             $date   = get_post_time( $gmt_s, $gmt, $topic_id );
             $time   = false; // For filter below
@@ -885 +885 @@
 
         // Bump if topic is in loop
-        if ( !bbp_show_lead_topic() ) {
+        if ( ! bbp_show_lead_topic() ) {
             $total++;
         }
@@ -903 +903 @@
         // Add pagination to query object
         $pagination_links = paginate_links( $pagination );
-        if ( !empty( $pagination_links ) ) {
+        if ( ! empty( $pagination_links ) ) {
 
             // Remove first page from pagination
@@ -977 +977 @@
         $revision_log = bbp_get_topic_raw_revision_log( $topic_id );
 
-        if ( empty( $topic_id ) || empty( $revision_log ) || !is_array( $revision_log ) ) {
+        if ( empty( $topic_id ) || empty( $revision_log ) || ! is_array( $revision_log ) ) {
             return false;
         }
@@ -1003 +1003 @@
 
             $r .= "\t" . '<li id="bbp-topic-revision-log-' . esc_attr( $topic_id ) . '-item-' . esc_attr( $revision->ID ) . '" class="bbp-topic-revision-log-item">' . "\n";
-            if ( !empty( $reason ) ) {
+            if ( ! empty( $reason ) ) {
                 $r .= "\t\t" . sprintf( __( 'This topic was modified %1$s by %2$s. Reason: %3$s', 'bbpress' ), esc_html( $since ), $author, esc_html( $reason ) ) . "\n";
             } else {
@@ -1115 +1115 @@
  */
 function bbp_is_topic_open( $topic_id = 0 ) {
-    return !bbp_is_topic_closed( $topic_id );
+    return ! bbp_is_topic_closed( $topic_id );
 }
 
@@ -1154 +1154 @@
     $stickies = bbp_get_stickies( $forum_id );
 
-    if ( in_array( $topic_id, $stickies ) || ( !empty( $check_super ) && bbp_is_topic_super_sticky( $topic_id ) ) ) {
+    if ( in_array( $topic_id, $stickies ) || ( ! empty( $check_super ) && bbp_is_topic_super_sticky( $topic_id ) ) ) {
         return true;
     }
@@ -1242 +1242 @@
     $retval   = false;
 
-    if ( !bbp_get_topic_author_id( $topic_id ) ) {
+    if ( ! bbp_get_topic_author_id( $topic_id ) ) {
         $retval = true;
 
@@ -1292 +1292 @@
         $topic_id = bbp_get_topic_id( $topic_id );
 
-        if ( !bbp_is_topic_anonymous( $topic_id ) ) {
+        if ( ! bbp_is_topic_anonymous( $topic_id ) ) {
             $author = get_the_author_meta( 'display_name', bbp_get_topic_author_id( $topic_id ) );
         } else {
@@ -1363 +1363 @@
 
         // Check for anonymous user
-        if ( !bbp_is_topic_anonymous( $topic_id ) ) {
+        if ( ! bbp_is_topic_anonymous( $topic_id ) ) {
 
             // Get the author ID
@@ -1427 +1427 @@
 
         $topic_id = bbp_get_topic_id( $topic_id );
-        if ( !empty( $topic_id ) ) {
-            if ( !bbp_is_topic_anonymous( $topic_id ) ) {
+        if ( ! empty( $topic_id ) ) {
+            if ( ! bbp_is_topic_anonymous( $topic_id ) ) {
                 $author_avatar = get_avatar( bbp_get_topic_author_id( $topic_id ), $size );
             } else {
@@ -1490 +1490 @@
 
         // Topic ID is good
-        if ( !empty( $topic_id ) ) {
+        if ( ! empty( $topic_id ) ) {
 
             // Get some useful topic information
@@ -1506 +1506 @@
 
             // Setup title and author_links array
-            $link_title   = !empty( $link_title ) ? ' title="' . esc_attr( $link_title ) . '"' : '';
+            $link_title   = ! empty( $link_title ) ? ' title="' . esc_attr( $link_title ) . '"' : '';
             $author_links = array();
 
@@ -1582 +1582 @@
 
         // Check for anonymous user or non-existant user
-        if ( !bbp_is_topic_anonymous( $topic_id ) && bbp_user_has_profile( bbp_get_topic_author_id( $topic_id ) ) ) {
+        if ( ! bbp_is_topic_anonymous( $topic_id ) && bbp_user_has_profile( bbp_get_topic_author_id( $topic_id ) ) ) {
             $author_url = bbp_get_user_profile_url( bbp_get_topic_author_id( $topic_id ) );
         } else {
@@ -1627 +1627 @@
 
         // Not anonymous user
-        if ( !bbp_is_topic_anonymous( $topic_id ) ) {
+        if ( ! bbp_is_topic_anonymous( $topic_id ) ) {
 
             // Use topic author email address
             $user_id      = bbp_get_topic_author_id( $topic_id );
             $user         = get_userdata( $user_id );
-            $author_email = !empty( $user->user_email ) ? $user->user_email : '';
+            $author_email = ! empty( $user->user_email ) ? $user->user_email : '';
 
         // Anonymous
@@ -1815 +1815 @@
         if ( empty( $last_active ) ) {
             $reply_id = bbp_get_topic_last_reply_id( $topic_id );
-            if ( !empty( $reply_id ) ) {
+            if ( ! empty( $reply_id ) ) {
                 $last_active = get_post_field( 'post_date', $reply_id );
             } else {
@@ -1822 +1822 @@
         }
 
-        $last_active = !empty( $last_active ) ? bbp_get_time_since( bbp_convert_date( $last_active ) ) : '';
+        $last_active = ! empty( $last_active ) ? bbp_get_time_since( bbp_convert_date( $last_active ) ) : '';
 
         // Return the time since
@@ -2037 +2037 @@
         $reply_id = bbp_get_topic_last_reply_id( $topic_id );
 
-        if ( !empty( $reply_id ) && ( $reply_id !== $topic_id ) ) {
+        if ( ! empty( $reply_id ) && ( $reply_id !== $topic_id ) ) {
             $reply_url = bbp_get_reply_url( $reply_id );
         } else {
@@ -2079 +2079 @@
         $time_since = bbp_get_topic_last_active_time( $topic_id );
 
-        if ( !empty( $time_since ) ) {
+        if ( ! empty( $time_since ) ) {
             $anchor = '<a href="' . esc_url( $link_url ) . '" title="' . esc_attr( $title ) . '">' . esc_html( $time_since ) . '</a>';
         } else {
@@ -2137 +2137 @@
 
         // This forum has hidden topics
-        if ( !empty( $deleted ) && current_user_can( 'edit_others_replies' ) ) {
+        if ( ! empty( $deleted ) && current_user_can( 'edit_others_replies' ) ) {
 
             // Extra text
@@ -2332 +2332 @@
 
             // If terms exist, explode them and compile the return value
-            if ( !empty( $terms ) ) {
+            if ( ! empty( $terms ) ) {
                 $terms  = implode( $r['sep'], $terms );
                 $retval = $r['before'] . $terms . $r['after'];
@@ -2520 +2520 @@
 
         // Bypass check if user has caps
-        if ( !current_user_can( 'edit_others_topics' ) ) {
+        if ( ! current_user_can( 'edit_others_topics' ) ) {
 
             // User cannot edit or it is past the lock time
-            if ( empty( $topic ) || !current_user_can( 'edit_topic', $topic->ID ) || bbp_past_edit_lock( $topic->post_date_gmt ) ) {
+            if ( empty( $topic ) || ! current_user_can( 'edit_topic', $topic->ID ) || bbp_past_edit_lock( $topic->post_date_gmt ) ) {
                 return;
             }
@@ -2648 +2648 @@
         $topic   = bbp_get_topic( bbp_get_topic_id( (int) $r['id'] ) );
 
-        if ( empty( $topic ) || !current_user_can( 'delete_topic', $topic->ID ) ) {
+        if ( empty( $topic ) || ! current_user_can( 'delete_topic', $topic->ID ) ) {
             return;
         }
@@ -2658 +2658 @@
         }
 
-        if ( bbp_is_topic_trash( $topic->ID ) || !EMPTY_TRASH_DAYS ) {
+        if ( bbp_is_topic_trash( $topic->ID ) || ! empty_TRASH_DAYS ) {
             $actions['delete']  = '<a title="' . esc_attr__( 'Delete this item permanently',     'bbpress' ) . '" href="' . esc_url( wp_nonce_url( add_query_arg( array( 'action' => 'bbp_toggle_topic_trash', 'sub_action' => 'delete',  'topic_id' => $topic->ID ) ), 'delete-'  . $topic->post_type . '_' . $topic->ID ) ) . '" onclick="return confirm(\'' . esc_js( __( 'Are you sure you want to delete that permanently?', 'bbpress' ) ) . '\' );" class="bbp-topic-delete-link">' . $r['delete_text'] . '</a>';
         }
@@ -2716 +2716 @@
         $topic = bbp_get_topic( bbp_get_topic_id( (int) $r['id'] ) );
 
-        if ( empty( $topic ) || !current_user_can( 'moderate', $topic->ID ) ) {
+        if ( empty( $topic ) || ! current_user_can( 'moderate', $topic->ID ) ) {
             return;
         }
@@ -2778 +2778 @@
         $topic = bbp_get_topic( bbp_get_topic_id( (int) $r['id'] ) );
 
-        if ( empty( $topic ) || !current_user_can( 'moderate', $topic->ID ) ) {
+        if ( empty( $topic ) || ! current_user_can( 'moderate', $topic->ID ) ) {
             return;
         }
@@ -2848 +2848 @@
         $topic = bbp_get_topic( bbp_get_topic_id( (int) $r['id'] ) );
 
-        if ( empty( $topic ) || !current_user_can( 'moderate', $topic->ID ) ) {
+        if ( empty( $topic ) || ! current_user_can( 'moderate', $topic->ID ) ) {
             return;
         }
@@ -2906 +2906 @@
         $topic = bbp_get_topic( bbp_get_topic_id( (int) $r['id'] ) );
 
-        if ( empty( $topic ) || !current_user_can( 'moderate', $topic->ID ) ) {
+        if ( empty( $topic ) || ! current_user_can( 'moderate', $topic->ID ) ) {
             return;
         }
@@ -3003 +3003 @@
         $from_num  = bbp_number_format( $start_num );
         $to_num    = bbp_number_format( ( $start_num + ( $bbp->topic_query->posts_per_page - 1 ) > $bbp->topic_query->found_posts ) ? $bbp->topic_query->found_posts : $start_num + ( $bbp->topic_query->posts_per_page - 1 ) );
-        $total_int = (int) !empty( $bbp->topic_query->found_posts ) ? $bbp->topic_query->found_posts : $bbp->topic_query->post_count;
+        $total_int = (int) ! empty( $bbp->topic_query->found_posts ) ? $bbp->topic_query->found_posts : $bbp->topic_query->post_count;
         $total     = bbp_number_format( $total_int );
 
@@ -3062 +3062 @@
 
     // Bail if not viewing a topic
-    if ( !bbp_is_single_topic() ) {
+    if ( ! bbp_is_single_topic() ) {
         return;
     }
@@ -3182 +3182 @@
 
         // Used variables
-        $tab = !empty( $r['tab'] ) ? ' tabindex="' . (int) $r['tab'] . '"' : '';
+        $tab = ! empty( $r['tab'] ) ? ' tabindex="' . (int) $r['tab'] . '"' : '';
 
         // Start an output buffer, we'll finish it after the select loop
@@ -3348 +3348 @@
         // Topic has replies
         $last_reply = bbp_get_topic_last_reply_id( $topic_id );
-        if ( !empty( $last_reply ) ) {
+        if ( ! empty( $last_reply ) ) {
             $last_updated_by = bbp_get_author_link( array( 'post_id' => $last_reply, 'size' => $r['size'] ) );
             $retstr          = sprintf( esc_html__( 'This topic contains %1$s, has %2$s, and was last updated by %3$s %4$s.', 'bbpress' ), $reply_count, $voice_count, $last_updated_by, $time_since );
@@ -3465 +3465 @@
 
         // Add before and after if description exists
-        if ( !empty( $term->term_id ) ) {
+        if ( ! empty( $term->term_id ) ) {
             $retval = $term->term_id;
 
@@ -3509 +3509 @@
 
         // Add before and after if description exists
-        if ( !empty( $term->name ) ) {
+        if ( ! empty( $term->name ) ) {
             $retval = $term->name;
 
@@ -3553 +3553 @@
 
         // Add before and after if description exists
-        if ( !empty( $term->slug ) ) {
+        if ( ! empty( $term->slug ) ) {
             $retval = $term->slug;
 
@@ -3597 +3597 @@
 
         // Add before and after if description exists
-        if ( !empty( $term->term_id ) ) {
+        if ( ! empty( $term->term_id ) ) {
             $retval = get_term_link( $term, bbp_get_topic_tag_tax_id() );
 
@@ -3642 +3642 @@
 
         // Add before and after if description exists
-        if ( !empty( $term->term_id ) ) {
+        if ( ! empty( $term->term_id ) ) {
 
             $bbp = bbpress();
@@ -3705 +3705 @@
 
         // Add before and after if description exists
-        if ( !empty( $term->description ) ) {
+        if ( ! empty( $term->description ) ) {
             $retval = $r['before'] . $term->description . $r['after'];
 
@@ -3845 +3845 @@
 
             // Topic exists
-            if ( !empty( $topic_id ) ) {
+            if ( ! empty( $topic_id ) ) {
 
                 // Topic is spammed so display pre-spam terms
@@ -3874 +3874 @@
 
             // Set the return value
-            $topic_tags = ( !empty( $new_terms ) ) ? implode( ', ', $new_terms ) : '';
+            $topic_tags = ( ! empty( $new_terms ) ) ? implode( ', ', $new_terms ) : '';
 
         // No data