Changeset 5378 for trunk/src/includes/topics/functions.php

Timestamp:

06/06/2014 07:38:59 PM (11 years ago)

Author:

johnjamesjacoby

Message:

Introduce bbp_validate_reply_to() function, used to:

• Validate a parent reply is actually a reply post_type.
• A reply is not accidentally assigning itself as its own parent.
• An integer is returned.

Fixes hiesenbug where calls to bbp_get_reply_id() were unexpectedly and occasionally returning the current reply ID rather than 0.

See #2588. (trunk)

File:

• trunk/src/includes/topics/functions.php (modified) (1 diff)

trunk/src/includes/topics/functions.php

@@ -1673 +1673 @@
 
             // New topic from reply can't be a reply to
-            if ( ( $from_reply->ID === $destination_topic->ID && $from_reply->ID === $reply_to ) ) {
+            if ( ( $from_reply->ID === $destination_topic->ID ) && ( $from_reply->ID === $reply_to ) ) {
                 bbp_update_reply_to( $reply->ID, 0 );
             }