Changeset 5305

Timestamp:

03/04/2014 06:06:45 AM (11 years ago)

Author:

nacin

Message:

bbPress 1.x: Allow log-in attempt even if we think the user is already logged in.

If your session cookie's internal expiration time has passed, we give you a grace period of one hour for POST and XHR requests. If within that hour you're trying to log in again, the grace period goes into effect for the POST. Then bb-login.php kicks you out because it thinks you're already logged in, instead of setting a new cookie for you.

So long, heisenbug.

File:

• branches/1.1/bb-login.php (modified) (1 diff)

branches/1.1/bb-login.php

@@ -66 +66 @@
         bb_logout();
 
-    bb_safe_redirect( $re );
-    exit;
+    // If POST, assume we're trying to log in. We may be logged in
+    // simply due to the 1-hour grace period afforded to POST requests.
+    if ( 'POST' !== $_SERVER['REQUEST_METHOD'] ) {
+        bb_safe_redirect( $re );
+        exit;
+    }
 }