Changeset 5257 for trunk/includes/forums/functions.php

Timestamp:

01/13/2014 11:53:30 PM (12 years ago)

Author:

netweb

Message:

Remove pre_get_posts action bbp_pre_get_posts_normalize_forum_visibility from forum visibility repair tool to prevent hidden and private post status injected into WP_Query. Props thebrandonallen. Fixes #2512

File:

• trunk/includes/forums/functions.php (modified) (2 diffs)

trunk/includes/forums/functions.php

@@ -930 +930 @@
     delete_option( '_bbp_private_forums' );
     delete_option( '_bbp_hidden_forums'  );
+    
+    /**
+     * Don't search for both private/hidden statuses. Since 'pre_get_posts' is an
+     * action, it's not removed by suppress_filters. We need to make sure that 
+     * we're only searching for the supplied post_status.
+     *
+     * @see https://bbpress.trac.wordpress.org/ticket/2512
+     */
+    remove_action( 'pre_get_posts', 'bbp_pre_get_posts_normalize_forum_visibility', 4 );
 
     // Next, get all the private and hidden forums
@@ -946 +955 @@
         'fields'           => 'ids'
     ) );
+    
+    // Enable forum visibilty normalization
+    add_action( 'pre_get_posts', 'bbp_pre_get_posts_normalize_forum_visibility', 4 );
 
     // Reset the $post global