Changeset 5242 for trunk/includes/admin/settings.php

Timestamp:

01/03/2014 07:40:38 AM (11 years ago)

Author:

johnjamesjacoby

Message:

For single admin settings that contain both checkboxes and select drop-downs, use two labels. Fixes poor UX in some browsers. Props netweb. Fixes #2393. (trunk)

File:

• trunk/includes/admin/settings.php (modified) (3 diffs)

trunk/includes/admin/settings.php

@@ -517 +517 @@
     ob_start(); ?>
 
-    <select name="_bbp_default_role" id="_bbp_default_role" <?php bbp_maybe_admin_setting_disabled( '_bbp_default_role' ); ?>>
-
+    </label>
+    <label for="_bbp_default_role">
+        <select name="_bbp_default_role" id="_bbp_default_role" <?php bbp_maybe_admin_setting_disabled( '_bbp_default_role' ); ?>>
         <?php foreach ( bbp_get_dynamic_roles() as $role => $details ) : ?>
 
@@ -524 +525 @@
 
         <?php endforeach; ?>
-
-    </select>
+        </select>
 
     <?php $select = ob_get_clean(); ?>
@@ -636 +636 @@
     ob_start(); ?>
 
-    <select name="_bbp_thread_replies_depth" id="_bbp_thread_replies_depth" <?php bbp_maybe_admin_setting_disabled( '_bbp_thread_replies_depth' ); ?>>
-    <?php for ( $i = 2; $i <= $max_depth; $i++ ) : ?>
-
-        <option value="<?php echo esc_attr( $i ); ?>" <?php selected( $i, $current_depth ); ?>><?php echo esc_html( $i ); ?></option>
-
-    <?php endfor; ?>
-    </select>
+    </label>
+    <label for="_bbp_thread_replies_depth">
+        <select name="_bbp_thread_replies_depth" id="_bbp_thread_replies_depth" <?php bbp_maybe_admin_setting_disabled( '_bbp_thread_replies_depth' ); ?>>
+        <?php for ( $i = 2; $i <= $max_depth; $i++ ) : ?>
+
+            <option value="<?php echo esc_attr( $i ); ?>" <?php selected( $i, $current_depth ); ?>><?php echo esc_html( $i ); ?></option>
+
+        <?php endfor; ?>
+        </select>
 
     <?php $select = ob_get_clean(); ?>