Changeset 5180

Timestamp:

11/24/2013 09:46:41 PM (7 years ago)

Author:

netweb

Message:

Protect topic and reply author link calls from non-existant users. Props jondavidjohn. Fixes #2381

Location:

trunk/includes

Files:

• replies/template.php (modified) (3 diffs)
• topics/template.php (modified) (2 diffs)
• users/template.php (modified) (2 diffs)

trunk/includes/replies/template.php

@@ -1232 +1232 @@
             $link_class = ' class="bbp-author-' . esc_attr( $r['type'] ) . '"';
 
-            // Add links if not anonymous
+            // Add links if not anonymous and existing user
             if ( empty( $anonymous ) && bbp_user_has_profile( bbp_get_reply_author_id( $reply_id ) ) ) {
 
@@ -1280 +1280 @@
      * @uses bbp_is_reply_anonymous() To check if the reply is by an anonymous
      *                                 user
+     * @uses bbp_user_has_profile() To check if the user has a profile
      * @uses bbp_get_reply_author_id() To get the reply author id
      * @uses bbp_get_user_profile_url() To get the user profile url
@@ -1290 +1291 @@
         $reply_id = bbp_get_reply_id( $reply_id );
 
-        // Check for anonymous user
-        if ( !bbp_is_reply_anonymous( $reply_id ) ) {
+        // Check for anonymous user or non-existant user
+        if ( !bbp_is_reply_anonymous( $reply_id ) && bbp_user_has_profile( bbp_get_reply_author_id( $reply_id ) ) ) {
             $author_url = bbp_get_user_profile_url( bbp_get_reply_author_id( $reply_id ) );
         } else {

trunk/includes/topics/template.php

@@ -1551 +1551 @@
      * @uses bbp_is_topic_anonymous() To check if the topic is by an anonymous
      *                                 user or not
+     * @uses bbp_user_has_profile() To check if the user has a profile
      * @uses bbp_get_topic_author_id() To get topic author id
      * @uses bbp_get_user_profile_url() To get profile url
@@ -1561 +1562 @@
         $topic_id = bbp_get_topic_id( $topic_id );
 
-        // Check for anonymous user
-        if ( !bbp_is_topic_anonymous( $topic_id ) ) {
+        // Check for anonymous user or non-existant user
+        if ( !bbp_is_topic_anonymous( $topic_id ) && bbp_user_has_profile( bbp_get_topic_author_id( $topic_id ) ) ) {
             $author_url = bbp_get_user_profile_url( bbp_get_topic_author_id( $topic_id ) );
         } else {

trunk/includes/users/template.php

@@ -1654 +1654 @@
             // Assemble some link bits
             $link_title = !empty( $r['link_title'] ) ? ' title="' . $r['link_title'] . '"' : '';
-            $author_url = bbp_get_user_profile_url( $user_id );
             $anonymous  = bbp_is_reply_anonymous( $r['post_id'] );
 
@@ -1669 +1668 @@
             // Add links if not anonymous
             if ( empty( $anonymous ) && bbp_user_has_profile( $user_id ) ) {
+                $author_url = bbp_get_user_profile_url( $user_id );
                 foreach ( $author_links as $link_text ) {
                     $author_link[] = sprintf( '<a href="%1$s"%2$s>%3$s</a>', $author_url, $link_title, $link_text );