Changeset 5060 for trunk/includes/admin/metaboxes.php

Timestamp:

08/02/2013 07:20:49 AM (13 years ago)

Author:

johnjamesjacoby

Message:

Normalize forum, topic, and reply dropdown form fields and associated functions. Includes several new functions with _get_ equivalents to replace incorrectly named _select() functions.

First pass at adding custom topic status handling. Props jkudish. See #2187.

Also replaces $wpdb->update() calls with wp_update_post() in associated functions. Fixes #2351.

File:

• trunk/includes/admin/metaboxes.php (modified) (4 diffs)

trunk/includes/admin/metaboxes.php

@@ -261 +261 @@
                 <strong class="label"><?php esc_html_e( 'Type:', 'bbpress' ); ?></strong>
                 <label class="screen-reader-text" for="bbp_forum_type_select"><?php esc_html_e( 'Type:', 'bbpress' ) ?></label>
-                <?php bbp_form_forum_type_dropdown( $post_id ); ?>
+                <?php bbp_form_forum_type_dropdown( array( 'forum_id' => $post_id ) ); ?>
         </p>
 
@@ -273 +273 @@
                 <strong class="label"><?php esc_html_e( 'Status:', 'bbpress' ); ?></strong>
                 <label class="screen-reader-text" for="bbp_forum_status_select"><?php esc_html_e( 'Status:', 'bbpress' ) ?></label>
-                <?php bbp_form_forum_status_dropdown( $post_id ); ?>
+                <?php bbp_form_forum_status_dropdown( array( 'forum_id' => $post_id ) ); ?>
         </p>
 
@@ -285 +285 @@
                 <strong class="label"><?php esc_html_e( 'Visibility:', 'bbpress' ); ?></strong>
                 <label class="screen-reader-text" for="bbp_forum_visibility_select"><?php esc_html_e( 'Visibility:', 'bbpress' ) ?></label>
-                <?php bbp_form_forum_visibility_dropdown( $post_id ); ?>
+                <?php bbp_form_forum_visibility_dropdown( array( 'forum_id' => $post_id ) ); ?>
         </p>
 
@@ -345 +345 @@
 
         // Post ID
-        $post_id = get_the_ID(); ?>
+        $post_id = get_the_ID();
+
+        /** Type ******************************************************************/
+
+        ?>
 
         <p>
                 <strong class="label"><?php esc_html_e( 'Type:', 'bbpress' ); ?></strong>
                 <label class="screen-reader-text" for="bbp_stick_topic"><?php esc_html_e( 'Topic Type', 'bbpress' ); ?></label>
-                <?php bbp_topic_type_select( array( 'topic_id' => $post_id ) ); ?>
-        </p>
+                <?php bbp_form_topic_type_dropdown( array( 'topic_id' => $post_id ) ); ?>
+        </p>
+
+        <?php
+
+        /** Status ****************************************************************/
+
+        ?>
+
+        <p>
+                <strong class="label"><?php esc_html_e( 'Status:', 'bbpress' ); ?></strong>
+                <label class="screen-reader-text" for="bbp_open_close_topic"><?php esc_html_e( 'Select whether to open or close the topic.', 'bbpress' ); ?></label>
+                <?php bbp_form_topic_status_dropdown( array( 'select_id' => 'post_status', 'topic_id' => $post_id ) ); ?>
+        </p>
+
+        <?php
+
+        /** Parent *****************************************************************/
+
+        ?>
 
         <p>