Changeset 5055 for trunk/includes/replies/functions.php

Timestamp:

07/29/2013 01:41:36 AM (13 years ago)

Author:

johnjamesjacoby

Message:

Switch some wp_insert_post() usages to wp_update_post(). Use bbp_get_forum(), bbp_get_topic(), and bbp_get_reply() where appropriate, and use objects instead of arrays to avoid escaping issues with wp_update_post().

File:

• trunk/includes/replies/functions.php (modified) (10 diffs)

trunk/includes/replies/functions.php

@@ -169 +169 @@
 
         // Topic does not exist
-        } elseif ( ! get_post( $posted_topic_id ) ) {
+        } elseif ( ! bbp_get_topic( $posted_topic_id ) ) {
             bbp_add_error( 'bbp_reply_topic_id', __( '<strong>ERROR</strong>: Topic does not exist.', 'bbpress' ) );
 
@@ -210 +210 @@
 
             // Forum does not exist
-            } elseif ( ! get_post( $posted_forum_id ) ) {
+            } elseif ( ! bbp_get_forum( $posted_forum_id ) ) {
                 bbp_add_error( 'bbp_topic_forum_id', __( '<strong>ERROR</strong>: Forum does not exist.', 'bbpress' ) );
 
@@ -1626 +1626 @@
  *
  * @param int $reply_id Reply id
- * @uses get_post() To get the reply
+ * @uses bbp_get_reply() To get the reply
  * @uses do_action() Calls 'bbp_spam_reply' with the reply ID
  * @uses add_post_meta() To add the previous status to a meta
- * @uses wp_insert_post() To insert the updated post
+ * @uses wp_update_post() To insert the updated post
  * @uses do_action() Calls 'bbp_spammed_reply' with the reply ID
  * @return mixed False or {@link WP_Error} on failure, reply id on success
@@ -1636 +1636 @@
 
     // Get reply
-    $reply = get_post( $reply_id, ARRAY_A );
+    $reply = bbp_get_reply( $reply_id );
     if ( empty( $reply ) )
         return $reply;
 
     // Bail if already spam
-    if ( bbp_get_spam_status_id() === $reply['post_status'] )
+    if ( bbp_get_spam_status_id() === $reply->post_status )
         return false;
 
@@ -1648 +1648 @@
 
     // Add the original post status as post meta for future restoration
-    add_post_meta( $reply_id, '_bbp_spam_meta_status', $reply['post_status'] );
+    add_post_meta( $reply_id, '_bbp_spam_meta_status', $reply->post_status );
 
     // Set post status to spam
-    $reply['post_status'] = bbp_get_spam_status_id();
+    $reply->post_status = bbp_get_spam_status_id();
 
     // No revisions
@@ -1657 +1657 @@
 
     // Update the reply
-    $reply_id = wp_insert_post( $reply );
+    $reply_id = wp_update_post( $reply );
 
     // Execute post spam code
@@ -1672 +1672 @@
  *
  * @param int $reply_id Reply id
- * @uses get_post() To get the reply
+ * @uses bbp_get_reply() To get the reply
  * @uses do_action() Calls 'bbp_unspam_reply' with the reply ID
  * @uses get_post_meta() To get the previous status meta
  * @uses delete_post_meta() To delete the previous status meta
- * @uses wp_insert_post() To insert the updated post
+ * @uses wp_update_post() To insert the updated post
  * @uses do_action() Calls 'bbp_unspammed_reply' with the reply ID
  * @return mixed False or {@link WP_Error} on failure, reply id on success
@@ -1683 +1683 @@
 
     // Get reply
-    $reply = get_post( $reply_id, ARRAY_A );
+    $reply = bbp_get_reply( $reply_id );
     if ( empty( $reply ) )
         return $reply;
 
     // Bail if already not spam
-    if ( bbp_get_spam_status_id() !== $reply['post_status'] )
+    if ( bbp_get_spam_status_id() !== $reply->post_status )
         return false;
 
@@ -1695 +1695 @@
 
     // Get pre spam status
-    $reply['post_status'] = get_post_meta( $reply_id, '_bbp_spam_meta_status', true );
+    $reply->post_status = get_post_meta( $reply_id, '_bbp_spam_meta_status', true );
 
     // If no previous status, default to publish
-    if ( empty( $reply['post_status'] ) ) {
-        $reply['post_status'] = bbp_get_public_status_id();
+    if ( empty( $reply->post_status ) ) {
+        $reply->post_status = bbp_get_public_status_id();
     }
 
@@ -1709 +1709 @@
 
     // Update the reply
-    $reply_id = wp_insert_post( $reply );
+    $reply_id = wp_update_post( $reply );
 
     // Execute post unspam code