Changeset 5037 for trunk/includes/topics/template-tags.php

Timestamp:

07/17/2013 07:35:03 PM (13 years ago)

Author:

johnjamesjacoby

Message:

For all template functions that output URL's, always echo an escaped value using esc_url(). See #2367.

File:

• trunk/includes/topics/template-tags.php (modified) (9 diffs)

trunk/includes/topics/template-tags.php

@@ -513 +513 @@
  */
 function bbp_topic_permalink( $topic_id = 0, $redirect_to = '' ) {
-    echo bbp_get_topic_permalink( $topic_id, $redirect_to );
+    echo esc_url( bbp_get_topic_permalink( $topic_id, $redirect_to ) );
 }
     /**
@@ -1477 +1477 @@
  */
 function bbp_topic_author_url( $topic_id = 0 ) {
-    echo bbp_get_topic_author_url( $topic_id );
+    echo esc_url( bbp_get_topic_author_url( $topic_id ) );
 }
 
@@ -1815 +1815 @@
  */
 function bbp_topic_last_reply_permalink( $topic_id = 0 ) {
-    echo bbp_get_topic_last_reply_permalink( $topic_id );
+    echo esc_url( bbp_get_topic_last_reply_permalink( $topic_id ) );
 }
     /**
@@ -1844 +1844 @@
  */
 function bbp_topic_last_reply_url( $topic_id = 0 ) {
-    echo bbp_get_topic_last_reply_url( $topic_id );
+    echo esc_url( bbp_get_topic_last_reply_url( $topic_id ) );
 }
     /**
@@ -1907 +1907 @@
 
         if ( !empty( $time_since ) )
-            $anchor = '<a href="' . $link_url . '" title="' . esc_attr( $title ) . '">' . $time_since . '</a>';
+            $anchor = '<a href="' . esc_url( $link_url ) . '" title="' . esc_attr( $title ) . '">' . esc_html( $time_since ) . '</a>';
         else
             $anchor = __( 'No Replies', 'bbpress' );
@@ -2359 +2359 @@
             return;
 
-        $retval = $r['link_before'] . '<a href="' . $uri . '">' . $r['edit_text'] . '</a>' . $r['link_after'];
+        $retval = $r['link_before'] . '<a href="' . esc_url( $uri ) . '">' . $r['edit_text'] . '</a>' . $r['link_after'];
 
         return apply_filters( 'bbp_get_topic_edit_link', $retval, $r );
@@ -2373 +2373 @@
  */
 function bbp_topic_edit_url( $topic_id = 0 ) {
-    echo bbp_get_topic_edit_url( $topic_id );
+    echo esc_url( bbp_get_topic_edit_url( $topic_id ) );
 }
     /**
@@ -3243 +3243 @@
  */
 function bbp_topic_tag_link( $tag = '' ) {
-    echo bbp_get_topic_tag_link( $tag );
+    echo esc_url( bbp_get_topic_tag_link( $tag ) );
 }
     /**
@@ -3287 +3287 @@
  */
 function bbp_topic_tag_edit_link( $tag = '' ) {
-    echo bbp_get_topic_tag_edit_link( $tag );
+    echo esc_url( bbp_get_topic_tag_edit_link( $tag ) );
 }
     /**