Changeset 5036

Timestamp:

07/16/2013 07:36:05 PM (13 years ago)

Author:

johnjamesjacoby

Message:

When splitting a topic, correctly update the 'menu_order' property of the new topic post.

• Replace instances of 'post_position' with 'menu_order'
• Make sure 'menu_order' is 0

Props lakrisgubben. Fixes #2295.

Location:

trunk/includes

Files:

• replies/functions.php (modified) (1 diff)
• topics/functions.php (modified) (2 diffs)

trunk/includes/replies/functions.php

@@ -1299 +1299 @@
                 // Update the reply
                 wp_update_post( array(
-                    'ID'            => $move_reply->ID,
-                    'post_title'    => sprintf( __( 'Reply To: %s', 'bbpress' ), $destination_topic->post_title ),
-                    'post_name'     => false, // will be automatically generated
-                    'post_parent'   => $destination_topic->ID,
-                    'post_position' => $reply_position,
-                    'guid'          => ''
+                    'ID'          => $move_reply->ID,
+                    'post_title'  => sprintf( __( 'Reply To: %s', 'bbpress' ), $destination_topic->post_title ),
+                    'post_name'   => false, // will be automatically generated
+                    'post_parent' => $destination_topic->ID,
+                    'menu_order'  => $reply_position,
+                    'guid'        => ''
                 ) );
 

trunk/includes/topics/functions.php

@@ -1513 +1513 @@
                         'post_type'   => bbp_get_topic_post_type(),
                         'post_parent' => $source_topic->post_parent,
+                        'menu_order'  => 0,
                         'guid'        => ''
                     ) );
@@ -1640 +1641 @@
             // Update the reply
             wp_update_post( array(
-                'ID'            => $reply->ID,
-                'post_title'    => sprintf( __( 'Reply To: %s', 'bbpress' ), $destination_topic->post_title ),
-                'post_name'     => false, // will be automatically generated
-                'post_parent'   => $destination_topic->ID,
-                'post_position' => $reply_position,
-                'guid'          => ''
+                'ID'          => $reply->ID,
+                'post_title'  => sprintf( __( 'Reply To: %s', 'bbpress' ), $destination_topic->post_title ),
+                'post_name'   => false, // will be automatically generated
+                'post_parent' => $destination_topic->ID,
+                'menu_order'  => $reply_position,
+                'guid'        => ''
             ) );