Changeset 5021 for trunk/includes/admin/topics.php

Timestamp:

07/10/2013 03:29:03 PM (13 years ago)

Author:

johnjamesjacoby

Message:

Use string values when comparing against super globals. Regression introduced in r4995. See #2358.

File:

• trunk/includes/admin/topics.php (modified) (1 diff)

trunk/includes/admin/topics.php

@@ -502 +502 @@
 
                     $is_sticky = bbp_is_topic_sticky( $topic_id );
-                    $is_super  = ( empty( $is_sticky ) && !empty( $_GET['super'] ) && 1 === (int) $_GET['super'] ) ? true : false;
-                    $message   = true === $is_sticky ? 'unsticked'     : 'sticked';
-                    $message   = true === $is_super  ? 'super_sticked' : $message;
-                    $success   = true === $is_sticky ? bbp_unstick_topic( $topic_id ) : bbp_stick_topic( $topic_id, $is_super );
+                    $is_super  = false === $is_sticky && !empty( $_GET['super'] ) && ( "1" === $_GET['super'] ) ? true : false;
+                    $message   = true  === $is_sticky ? 'unsticked'     : 'sticked';
+                    $message   = true  === $is_super  ? 'super_sticked' : $message;
+                    $success   = true  === $is_sticky ? bbp_unstick_topic( $topic_id ) : bbp_stick_topic( $topic_id, $is_super );
 
                     break;