Changeset 4995 for trunk/includes/replies/template-tags.php

Timestamp:

06/23/2013 06:37:22 AM (13 years ago)

Author:

johnjamesjacoby

Message:

Use strict comparisons where possible (excluding the converter code, as it needs dedicated testing.) See #2358.

File:

• trunk/includes/replies/template-tags.php (modified) (9 diffs)

trunk/includes/replies/template-tags.php

@@ -151 +151 @@
 
                 // Make sure it's a reply to a reply
-                if ( empty( $reply_to ) || ( bbp_get_reply_topic_id( $post->ID ) == $reply_to ) ) {
+                if ( empty( $reply_to ) || ( bbp_get_reply_topic_id( $post->ID ) === $reply_to ) ) {
                     $reply_to = 0;
                 }
@@ -342 +342 @@
         return null;
 
-    if ( $output == OBJECT ) {
+    if ( $output === OBJECT ) {
         return $reply;
 
-    } elseif ( $output == ARRAY_A ) {
+    } elseif ( $output === ARRAY_A ) {
         $_reply = get_object_vars( $reply );
         return $_reply;
 
-    } elseif ( $output == ARRAY_N ) {
+    } elseif ( $output === ARRAY_N ) {
         $_reply = array_values( get_object_vars( $reply ) );
         return $_reply;
@@ -827 +827 @@
  */
 function bbp_is_reply_published( $reply_id = 0 ) {
-    $reply_status = bbp_get_reply_status( bbp_get_reply_id( $reply_id ) ) == bbp_get_public_status_id();
+    $reply_status = bbp_get_reply_status( bbp_get_reply_id( $reply_id ) ) === bbp_get_public_status_id();
     return (bool) apply_filters( 'bbp_is_reply_published', (bool) $reply_status, $reply_id );
 }
@@ -842 +842 @@
  */
 function bbp_is_reply_spam( $reply_id = 0 ) {
-    $reply_status = bbp_get_reply_status( bbp_get_reply_id( $reply_id ) ) == bbp_get_spam_status_id();
+    $reply_status = bbp_get_reply_status( bbp_get_reply_id( $reply_id ) ) === bbp_get_spam_status_id();
     return (bool) apply_filters( 'bbp_is_reply_spam', (bool) $reply_status, $reply_id );
 }
@@ -857 +857 @@
  */
 function bbp_is_reply_trash( $reply_id = 0 ) {
-    $reply_status = bbp_get_reply_status( bbp_get_reply_id( $reply_id ) ) == bbp_get_trash_status_id();
+    $reply_status = bbp_get_reply_status( bbp_get_reply_id( $reply_id ) ) === bbp_get_trash_status_id();
     return (bool) apply_filters( 'bbp_is_reply_trash', (bool) $reply_status, $reply_id );
 }
@@ -1132 +1132 @@
 
             // Get avatar
-            if ( 'avatar' == $r['type'] || 'both' == $r['type'] ) {
+            if ( 'avatar' === $r['type'] || 'both' === $r['type'] ) {
                 $author_links['avatar'] = bbp_get_reply_author_avatar( $reply_id, $r['size'] );
             }
 
             // Get display name
-            if ( 'name' == $r['type']   || 'both' == $r['type'] ) {
+            if ( 'name' === $r['type']   || 'both' === $r['type'] ) {
                 $author_links['name'] = bbp_get_reply_author_display_name( $reply_id );
             }
@@ -1450 +1450 @@
         $ancestor_id = $reply_id;
         while ( $parent_id = bbp_get_reply_to( $ancestor_id ) ) {
-            if ( empty( $parent_id ) || ( $parent_id === $ancestor_id ) || ( bbp_get_reply_topic_id( $reply_id ) === $parent_id ) || ( $parent_id == $reply_id ) ) {
+            if ( empty( $parent_id ) || ( $parent_id === $ancestor_id ) || ( bbp_get_reply_topic_id( $reply_id ) === $parent_id ) || ( $parent_id === $reply_id ) ) {
                 break;
             }
@@ -1656 +1656 @@
 
             // Post is not the topic
-            if ( $reply_id != $topic_id ) {
+            if ( $reply_id !== $topic_id ) {
                 $reply_position = bbp_get_reply_position_raw( $reply_id, $topic_id );
 
@@ -2199 +2199 @@
         $classes[] = 'bbp-reply-position-' . bbp_get_reply_position( $reply_id );
         $classes[] = 'user-id-' . bbp_get_reply_author_id( $reply_id );
-        $classes[] = ( bbp_get_reply_author_id( $reply_id ) == bbp_get_topic_author_id( bbp_get_reply_topic_id( $reply_id ) ) ? 'topic-author' : '' );
+        $classes[] = ( bbp_get_reply_author_id( $reply_id ) === bbp_get_topic_author_id( bbp_get_reply_topic_id( $reply_id ) ) ? 'topic-author' : '' );
         $classes   = array_filter( $classes );
         $classes   = get_post_class( $classes, $reply_id );