Changeset 4896 for trunk/includes/forums/functions.php

Timestamp:

05/11/2013 06:10:20 AM (13 years ago)

Author:

johnjamesjacoby

Message:

Use implode() instead of join() through-out project. See #2331.

File:

• trunk/includes/forums/functions.php (modified) (4 diffs)

trunk/includes/forums/functions.php

@@ -1363 +1363 @@
         // Get topics of forum
         if ( empty( $topic_count ) )
-            $topic_count = $wpdb->get_var( $wpdb->prepare( "SELECT COUNT(ID) FROM {$wpdb->posts} WHERE post_parent = %d AND post_status IN ( '" . join( '\',\'', array( bbp_get_trash_status_id(), bbp_get_spam_status_id() ) ) . "') AND post_type = '%s';", $forum_id, bbp_get_topic_post_type() ) );
+            $topic_count = $wpdb->get_var( $wpdb->prepare( "SELECT COUNT(ID) FROM {$wpdb->posts} WHERE post_parent = %d AND post_status IN ( '" . implode( '\',\'', array( bbp_get_trash_status_id(), bbp_get_spam_status_id() ) ) . "') AND post_type = '%s';", $forum_id, bbp_get_topic_post_type() ) );
 
         // Update the count
@@ -1410 +1410 @@
     $topic_ids = bbp_forum_query_topic_ids( $forum_id );
     if ( !empty( $topic_ids ) ) {
-        $reply_count = (int) $wpdb->get_var( $wpdb->prepare( "SELECT COUNT(ID) FROM {$wpdb->posts} WHERE post_parent IN ( " . join( ',', $topic_ids ) . " ) AND post_status = '%s' AND post_type = '%s';", bbp_get_public_status_id(), bbp_get_reply_post_type() ) );
+        $reply_count = (int) $wpdb->get_var( $wpdb->prepare( "SELECT COUNT(ID) FROM {$wpdb->posts} WHERE post_parent IN ( " . implode( ',', $topic_ids ) . " ) AND post_status = '%s' AND post_type = '%s';", bbp_get_public_status_id(), bbp_get_reply_post_type() ) );
     } else {
         $reply_count = 0;
@@ -1806 +1806 @@
 
         if ( !empty( $topic_ids ) ) {
-            $reply_id = (int) $wpdb->get_var( $wpdb->prepare( "SELECT ID FROM {$wpdb->posts} WHERE post_parent IN ( " . join( ',', $topic_ids ) . " ) AND post_status = '%s' AND post_type = '%s' ORDER BY ID DESC LIMIT 1;", bbp_get_public_status_id(), bbp_get_reply_post_type() ) );
+            $reply_id = (int) $wpdb->get_var( $wpdb->prepare( "SELECT ID FROM {$wpdb->posts} WHERE post_parent IN ( " . implode( ',', $topic_ids ) . " ) AND post_status = '%s' AND post_type = '%s' ORDER BY ID DESC LIMIT 1;", bbp_get_public_status_id(), bbp_get_reply_post_type() ) );
             wp_cache_set( $cache_id, $reply_id, 'bbpress_posts' ); // May be (int) 0
         } else {
@@ -2022 +2022 @@
 
     // Allowed post statuses to pre-trash
-    $post_stati = join( ',', array(
+    $post_stati = implode( ',', array(
         bbp_get_public_status_id(),
         bbp_get_closed_status_id(),