Changeset 4896 for trunk/includes/admin/tools.php

Timestamp:

05/11/2013 06:10:20 AM (13 years ago)

Author:

johnjamesjacoby

Message:

Use implode() instead of join() through-out project. See #2331.

File:

• trunk/includes/admin/tools.php (modified) (8 diffs)

trunk/includes/admin/tools.php

@@ -131 +131 @@
 
             default:
-                $message = '<ul>' . "\n\t" . '<li>' . join( '</li>' . "\n\t" . '<li>', $errors ) . '</li>' . "\n" . '</ul>';
+                $message = '<ul>' . "\n\t" . '<li>' . implode( '</li>' . "\n\t" . '<li>', $errors ) . '</li>' . "\n" . '</ul>';
                 break;
         }
@@ -286 +286 @@
         return array( 1, sprintf( $statement, $result ) );
 
-    $sql = "INSERT INTO `{$wpdb->postmeta}` (`post_id`, `meta_key`, `meta_value`) (SELECT `post_parent`, '_bbp_reply_count_hidden', COUNT(`post_status`) as `meta_value` FROM `{$wpdb->posts}` WHERE `post_type` = '" . bbp_get_reply_post_type() . "' AND `post_status` IN ( '" . join( "','", array( bbp_get_trash_status_id(), bbp_get_spam_status_id() ) ) . "') GROUP BY `post_parent`);";
+    $sql = "INSERT INTO `{$wpdb->postmeta}` (`post_id`, `meta_key`, `meta_value`) (SELECT `post_parent`, '_bbp_reply_count_hidden', COUNT(`post_status`) as `meta_value` FROM `{$wpdb->posts}` WHERE `post_type` = '" . bbp_get_reply_post_type() . "' AND `post_status` IN ( '" . implode( "','", array( bbp_get_trash_status_id(), bbp_get_spam_status_id() ) ) . "') GROUP BY `post_parent`);";
     if ( is_wp_error( $wpdb->query( $sql ) ) )
         return array( 2, sprintf( $statement, $result ) );
@@ -528 +528 @@
 
     foreach ( array_chunk( $insert_values, 10000 ) as $chunk ) {
-        $chunk = "\n" . join( ",\n", $chunk );
+        $chunk = "\n" . implode( ",\n", $chunk );
         $sql_insert = "INSERT INTO `{$wpdb->usermeta}` (`user_id`, `meta_key`, `meta_value`) VALUES $chunk;";
 
@@ -573 +573 @@
 
     foreach ( array_chunk( $insert_values, 10000 ) as $chunk ) {
-        $chunk = "\n" . join( ",\n", $chunk );
+        $chunk = "\n" . implode( ",\n", $chunk );
         $sql_insert = "INSERT INTO `{$wpdb->usermeta}` (`user_id`, `meta_key`, `meta_value`) VALUES $chunk;";
 
@@ -619 +619 @@
             continue;
 
-        $favorites_joined = join( ',', $favorites );
+        $favorites_joined = implode( ',', $favorites );
         $values[]         = "('{$user->user_id}', '{$key}, '{$favorites_joined}')";
 
@@ -636 +636 @@
 
     foreach ( array_chunk( $values, 10000 ) as $chunk ) {
-        $chunk = "\n" . join( ",\n", $chunk );
+        $chunk = "\n" . implode( ",\n", $chunk );
         $sql_insert = "INSERT INTO `$wpdb->usermeta` (`user_id`, `meta_key`, `meta_value`) VALUES $chunk;";
         if ( is_wp_error( $wpdb->query( $sql_insert ) ) ) {
@@ -680 +680 @@
             continue;
 
-        $subscriptions_joined = join( ',', $subscriptions );
+        $subscriptions_joined = implode( ',', $subscriptions );
         $values[]             = "('{$user->user_id}', '{$key}', '{$subscriptions_joined}')";
 
@@ -697 +697 @@
 
     foreach ( array_chunk( $values, 10000 ) as $chunk ) {
-        $chunk = "\n" . join( ",\n", $chunk );
+        $chunk = "\n" . implode( ",\n", $chunk );
         $sql_insert = "INSERT INTO `{$wpdb->usermeta}` (`user_id`, `meta_key`, `meta_value`) VALUES $chunk;";
         if ( is_wp_error( $wpdb->query( $sql_insert ) ) ) {