Skip to:
Content

bbPress.org

Changeset 4783


Ignore:
Timestamp:
02/28/2013 05:15:01 PM (13 years ago)
Author:
johnjamesjacoby
Message:

Replace is_super_admin() usages with bbp_is_user_keymaster() where appropriate. Fixes #2231.

Location:
trunk
Files:
13 edited

Legend:

Unmodified
Added
Removed
  • trunk/includes/admin/users.php

    r4682 r4783  
    7777
    7878        // Only keymasters can set other keymasters
    79         if ( ! current_user_can( 'keep_gate' ) )
     79        if ( ! bbp_is_user_keymaster() )
    8080            unset( $dynamic_roles[ bbp_get_keymaster_role() ] ); ?>
    8181
     
    133133
    134134        // Only keymasters can set other keymasters
    135         if ( ! current_user_can( 'keep_gate' ) )
     135        if ( ! bbp_is_user_keymaster() )
    136136            unset( $dynamic_roles[ bbp_get_keymaster_role() ] ); ?>
    137137
     
    190190
    191191            // Only keymasters can set other keymasters
    192             if ( in_array( bbp_get_keymaster_role(), array( $user_role, $new_role ) ) && ! current_user_can( 'keep_gate' ) )
     192            if ( in_array( bbp_get_keymaster_role(), array( $user_role, $new_role ) ) && ! bbp_is_user_keymaster() )
    193193                continue;
    194194
  • trunk/includes/common/functions.php

    r4775 r4783  
    762762 * @param string $title The title of the content
    763763 * @param string $content The content being posted
    764  * @uses is_super_admin() Allow super admins to bypass blacklist
     764 * @uses bbp_is_user_keymaster() Allow keymasters to bypass blacklist
    765765 * @uses bbp_current_author_ip() To get current user IP address
    766766 * @uses bbp_current_author_ua() To get current user agent
     
    773773        return true;
    774774
    775     // Bail if super admin is author
    776     if ( is_super_admin( $author_id ) )
     775    // Bail if keymaster is author
     776    if ( bbp_is_user_keymaster( $author_id ) )
    777777        return true;
    778778
     
    881881 * @param string $title The title of the content
    882882 * @param string $content The content being posted
    883  * @uses is_super_admin() Allow super admins to bypass blacklist
     883 * @uses bbp_is_user_keymaster() Allow keymasters to bypass blacklist
    884884 * @uses bbp_current_author_ip() To get current user IP address
    885885 * @uses bbp_current_author_ua() To get current user agent
     
    892892        return true;
    893893
    894     // Bail if super admin is author
    895     if ( is_super_admin( $author_id ) )
     894    // Bail if keymaster is author
     895    if ( bbp_is_user_keymaster( $author_id ) )
    896896        return true;
    897897
  • trunk/includes/extend/buddypress/group.php

    r4777 r4783  
    261261            </div>
    262262
    263             <?php if ( is_super_admin() ) : ?>
     263            <?php if ( bbp_is_user_keymaster() ) : ?>
    264264                <div class="field-group">
    265265                    <label for="bbp_group_forum_id"><?php _e( 'Group Forum:', 'bbpress' ); ?></label>
     
    307307        $group_id     = bp_get_current_group_id();
    308308
    309         // Super admins have the ability to reconfigure forums
    310         if ( is_super_admin() ) {
     309        // Keymasters have the ability to reconfigure forums
     310        if ( bbp_is_user_keymaster() ) {
    311311            $forum_ids = ! empty( $_POST['bbp_group_forum_id'] ) ? (array) (int) $_POST['bbp_group_forum_id'] : array();
    312312
     
    869869     * @param bool $retval Are we allowed to view the reply form?
    870870     * @uses bp_is_group() To determine if we're on a group page
    871      * @uses bp_loggedin_user_id() To determine if a user is logged in.
    872      * @uses bp_group_is_member() Is the current user a member of the group?
    873      * @uses bp_group_is_user_banned() Is the current user banned from the group?
     871     * @uses is_user_logged_in() To determine if a user is logged in.
     872     * @uses bbp_is_user_keymaster() Is the current user a keymaster?
     873     * @uses bbp_group_is_member() Is the current user a member of the group?
     874     * @uses bbp_group_is_user_banned() Is the current user banned from the group?
    874875     *
    875876     * @return bool
     
    886887            return $retval;
    887888
    888         // Admins can always pass go
    889         } elseif ( is_super_admin() ) {
     889        // Keymasters can always pass go
     890        } elseif ( bbp_is_user_keymaster() ) {
    890891            $retval = true;
    891892
  • trunk/includes/forums/functions.php

    r4724 r4783  
    15361536 * @param string Optional. The type of value to return. (string|array|meta_query)
    15371537 *
    1538  * @uses is_super_admin()
     1538 * @uses bbp_is_user_keymaster()
    15391539 * @uses bbp_get_hidden_forum_ids()
    15401540 * @uses bbp_get_private_forum_ids()
     
    15611561    }
    15621562   
    1563     // Exclude for everyone but super admins
    1564     if ( !is_super_admin() ) {
     1563    // Exclude for everyone but keymasters
     1564    if ( ! bbp_is_user_keymaster() ) {
    15651565
    15661566        // Private forums
     
    17951795 * @uses current_user_can() To check if the current user can read private forums
    17961796 * @uses is_singular() To check if it's a singular page
     1797 * @uses bbp_is_user_keymaster() To check if user is a keymaster
    17971798 * @uses bbp_get_forum_post_type() To get the forum post type
    17981799 * @uses bbp_get_topic_post_type() To get the topic post type
     
    18061807
    18071808    // Bail if not viewing a single item or if user has caps
    1808     if ( !is_singular() || is_super_admin() || current_user_can( 'read_hidden_forums' ) )
     1809    if ( !is_singular() || bbp_is_user_keymaster() || current_user_can( 'read_hidden_forums' ) )
    18091810        return;
    18101811
     
    18471848 * @uses current_user_can() To check if the current user can read private forums
    18481849 * @uses is_singular() To check if it's a singular page
     1850 * @uses bbp_is_user_keymaster() To check if user is a keymaster
    18491851 * @uses bbp_get_forum_post_type() To get the forum post type
    18501852 * @uses bbp_get_topic_post_type() To get the topic post type
     
    18581860
    18591861    // Bail if not viewing a single item or if user has caps
    1860     if ( !is_singular() || is_super_admin() || current_user_can( 'read_private_forums' ) )
     1862    if ( !is_singular() || bbp_is_user_keymaster() || current_user_can( 'read_private_forums' ) )
    18611863        return;
    18621864
  • trunk/includes/forums/template-tags.php

    r4775 r4783  
    624624
    625625    // Super admin get whitelisted post statuses
    626     if ( is_super_admin() ) {
     626    if ( bbp_is_user_keymaster() ) {
    627627        $post_stati = array( bbp_get_public_status_id(), bbp_get_private_status_id(), bbp_get_hidden_status_id() );
    628628
    629     // Not a super admin, so check caps
     629    // Not a keymaster, so check caps
    630630    } else {
    631631
  • trunk/includes/topics/template-tags.php

    r4781 r4783  
    28912891    $tab             = !empty( $r['tab'] ) ? ' tabindex="' . $r['tab'] . '"' : '';
    28922892    $select_id       = esc_attr( $r['select_id'] );
    2893     $sticky_statuses = array (
     2893    $sticky_statuses = array_filter( array(
    28942894        'unstick' => $r['unstick_text'],
    28952895        'stick'   => $r['stick_text'],
    28962896        'super'   => $r['super_text'],
    2897     ); ?>
     2897    ) ); ?>
    28982898
    28992899    <select name="<?php echo $select_id; ?>" id="<?php echo $select_id; ?>"<?php echo $tab; ?>>
  • trunk/includes/users/capabilities.php

    r4758 r4783  
    364364 * @uses bbp_is_user_home()
    365365 * @uses bbp_get_displayed_user_field()
    366  * @uses is_super_admin()
     366 * @uses bbp_is_user_keymaster()
    367367 * @uses get_blogs_of_user()
    368368 * @uses get_current_blog_id()
     
    387387        return false;
    388388
    389     // Bail if user ID is super admin
    390     if ( is_super_admin( $user_id ) )
     389    // Bail if user ID is keymaster
     390    if ( bbp_is_user_keymaster( $user_id ) )
    391391        return false;
    392392
     
    453453 * @uses bbp_is_user_home()
    454454 * @uses bbp_get_displayed_user_field()
    455  * @uses is_super_admin()
     455 * @uses bbp_is_user_keymaster()
    456456 * @uses get_blogs_of_user()
    457457 * @uses bbp_get_topic_post_type()
     
    475475        return false;
    476476
    477     // Bail if user ID is super admin
    478     if ( is_super_admin( $user_id ) )
     477    // Bail if user ID is keymaster
     478    if ( bbp_is_user_keymaster( $user_id ) )
    479479        return false;
    480480
     
    628628
    629629/**
     630 * Checks if user is a keymaster
     631 *
     632 * @since bbPress (r4783)
     633 *
     634 * @param int $user_id
     635 * @return bool True if keymaster, false if not
     636 */
     637function bbp_is_user_keymaster( $user_id = 0 ) {
     638
     639    // Default to current user ID if none is passed
     640    $_user_id = (int) ! empty( $user_id ) ? $user_id : bbp_get_current_user_id();
     641
     642    // Filter and return
     643    return (bool) apply_filters( 'bbp_is_user_keymaster', user_can( $user_id, 'keep_gate' ), $_user_id, $user_id );
     644}
     645
     646/**
    630647 * Does a user have a profile for the current site
    631648 *
     
    637654 * @uses bbp_get_user_id() To verify the user ID
    638655 * @uses get_userdata() To get the user's data
    639  * @uses is_super_admin() To determine if user can see inactive users
     656 * @uses bbp_is_user_keymaster() To determine if user can see inactive users
    640657 * @uses bbp_is_user_inactive() To check if user is spammer or deleted
    641658 * @uses apply_filters() To allow override of this functions result
     
    658675        $retval = false;
    659676
    660     // User is inactive, and current user is not a super admin
    661     } elseif ( ! is_super_admin() && bbp_is_user_inactive( $user->ID ) ) {
     677    // User is inactive, and current user is not a keymaster
     678    } elseif ( ! bbp_is_user_keymaster() && bbp_is_user_inactive( $user->ID ) ) {
    662679        $retval = false;
    663680    }
  • trunk/includes/users/functions.php

    r4715 r4783  
    859859 * @uses wpdb::get_blog_prefix() To get the blog prefix
    860860 * @uses is_network_admin() To check if the user is the network admin
    861  * @uses is_super_admin() To check if the user is super admin
    862861 * @uses revoke_super_admin() To revoke super admin priviledges
    863862 * @uses grant_super_admin() To grant super admin priviledges
     
    10931092 *
    10941093 * @uses is_user_logged_in() To check if user is logged in
    1095  * @uses is_super_admin() To check if user is a super admin
     1094 * @uses bbp_is_user_keymaster() To check if user is a keymaster
    10961095 * @uses current_user_can() To check if the current user can spectate
    10971096 * @uses is_bbpress() To check if in a bbPress section of the site
     
    11001099function bbp_forum_enforce_blocked() {
    11011100
    1102     // Bail if not logged in or super admin
    1103     if ( ! is_user_logged_in() || is_super_admin() ) {
     1101    // Bail if not logged in or keymaster
     1102    if ( ! is_user_logged_in() || bbp_is_user_keymaster() ) {
    11041103        return;
    11051104    }
  • trunk/includes/users/template-tags.php

    r4775 r4783  
    4646
    4747        // Currently viewing or editing a user
    48         } elseif ( ( true == $displayed_user_fallback ) && !empty( $bbp->displayed_user->ID ) ) {
     48        } elseif ( ( true === $displayed_user_fallback ) && !empty( $bbp->displayed_user->ID ) ) {
    4949            $bbp_user_id = $bbp->displayed_user->ID;
    5050
    5151        // Maybe fallback on the current_user ID
    52         } elseif ( ( true == $current_user_fallback ) && !empty( $bbp->current_user->ID ) ) {
     52        } elseif ( ( true === $current_user_fallback ) && !empty( $bbp->current_user->ID ) ) {
    5353            $bbp_user_id = $bbp->current_user->ID;
    5454
     
    471471     * @param int $user_id
    472472     * @uses bbp_get_user_id() to verify the user ID
    473      * @uses is_super_admin() to check if user is a super admin
     473     * @uses bbp_is_user_keymaster() to check if user is a keymaster
    474474     * @uses bbp_is_user_inactive() to check if user is inactive
    475475     * @uses user_can() to check if user has special capabilities
     
    484484
    485485        // Capes earn Vinz Clortho status
    486         if ( is_super_admin( $user_id ) ) {
     486        if ( bbp_is_user_keymaster( $user_id ) ) {
    487487            $role = __( 'Key Master', 'bbpress' );
    488488
     
    10581058
    10591059    // Only keymasters can set other keymasters
    1060     if ( ! current_user_can( 'keep_gate' ) )
     1060    if ( ! bbp_is_user_keymaster() )
    10611061        unset( $dynamic_roles[ bbp_get_keymaster_role() ] ); ?>
    10621062
     
    14741474 * @uses bbp_get_user_id()
    14751475 * @uses current_user_can()
    1476  * @uses is_super_admin()
     1476 * @uses bbp_is_user_keymaster()
    14771477 * @uses bbp_is_forum_public()
    14781478 * @uses bbp_is_forum_private()
     
    14971497    $retval   = false;
    14981498
    1499     // User is a super admin
    1500     if ( is_super_admin() ) {
     1499    // User is a keymaster
     1500    if ( bbp_is_user_keymaster() ) {
    15011501        $retval = true;
    15021502
     
    15221522 * @since bbPress (r3127)
    15231523 *
    1524  * @uses is_super_admin()
     1524 * @uses bbp_is_user_keymaster()
    15251525 * @uses is_user_logged_in()
    15261526 * @uses bbp_allow_anonymous()
     
    15361536    $retval = false;
    15371537
    1538     // Always allow super admins
    1539     if ( is_super_admin() ) {
     1538    // Always allow keymasters
     1539    if ( bbp_is_user_keymaster() ) {
    15401540        $retval = true;
    15411541
     
    15581558 * @since bbPress (r3549)
    15591559 *
    1560  * @uses is_super_admin()
     1560 * @uses bbp_is_user_keymaster()
    15611561 * @uses bbp_is_user_active()
    15621562 * @uses current_user_can()
     
    15701570    $retval = false;
    15711571
    1572     // Always allow super admins
    1573     if ( is_super_admin() ) {
     1572    // Always allow keymasters
     1573    if ( bbp_is_user_keymaster() ) {
    15741574        $retval = true;
    15751575
     
    15881588 * @since bbPress (r3127)
    15891589 *
    1590  * @uses is_super_admin()
     1590 * @uses bbp_is_user_keymaster()
    15911591 * @uses is_user_logged_in()
    15921592 * @uses bbp_allow_anonymous()
     
    16021602    $retval = false;
    16031603
    1604     // Always allow super admins
    1605     if ( is_super_admin() ) {
     1604    // Always allow keymasters
     1605    if ( bbp_is_user_keymaster() ) {
    16061606        $retval = true;
    16071607
     
    16201620
    16211621/** Forms *********************************************************************/
     1622
     1623/**
     1624 * The following functions should be turned into mapped meta capabilities in a
     1625 * future version. They exist only to remove complex logistical capability
     1626 * checks from within template parts.
     1627 */
    16221628
    16231629/**
     
    16751681 * @since bbPress (r3549)
    16761682 *
     1683 * @uses bbp_is_user_keymaster()
    16771684 * @uses bbp_is_forum_edit()
    16781685 * @uses current_user_can()
     
    16861693    $retval = false;
    16871694
    1688     // Always allow super admins
    1689     if ( is_super_admin() ) {
     1695    // Always allow keymasters
     1696    if ( bbp_is_user_keymaster() ) {
    16901697        $retval = true;
    16911698
     
    17081715 * @since bbPress (r3127)
    17091716 *
     1717 * @uses bbp_is_user_keymaster()
    17101718 * @uses bbp_is_topic_edit()
    17111719 * @uses current_user_can()
     
    17211729    $retval = false;
    17221730
    1723     // Always allow super admins
    1724     if ( is_super_admin() ) {
     1731    // Always allow keymasters
     1732    if ( bbp_is_user_keymaster() ) {
    17251733        $retval = true;
    17261734
     
    17431751 * @since bbPress (r3127)
    17441752 *
     1753 * @uses bbp_is_user_keymaster()
    17451754 * @uses bbp_is_topic_edit()
    17461755 * @uses current_user_can()
     
    17561765    $retval = false;
    17571766
    1758     // Always allow super admins
    1759     if ( is_super_admin() ) {
     1767    // Always allow keymasters
     1768    if ( bbp_is_user_keymaster() ) {
    17601769        $retval = true;
    17611770
  • trunk/templates/default/bbpress/content-single-topic-lead.php

    r4733 r4783  
    5858                <?php bbp_topic_author_link( array( 'sep' => '<br />', 'show_role' => true ) ); ?>
    5959
    60                 <?php if ( is_super_admin() ) : ?>
     60                <?php if ( bbp_is_user_keymaster() ) : ?>
    6161
    6262                    <?php do_action( 'bbp_theme_before_topic_author_admin_details' ); ?>
  • trunk/templates/default/bbpress/loop-search-reply.php

    r4579 r4783  
    4343        <?php bbp_reply_author_link( array( 'sep' => '<br />', 'show_role' => true ) ); ?>
    4444
    45         <?php if ( is_super_admin() ) : ?>
     45        <?php if ( bbp_is_user_keymaster() ) : ?>
    4646
    4747            <?php do_action( 'bbp_theme_before_reply_author_admin_details' ); ?>
  • trunk/templates/default/bbpress/loop-search-topic.php

    r4579 r4783  
    6363        <?php bbp_topic_author_link( array( 'sep' => '<br />', 'show_role' => true ) ); ?>
    6464
    65         <?php if ( is_super_admin() ) : ?>
     65        <?php if ( bbp_is_user_keymaster() ) : ?>
    6666
    6767            <?php do_action( 'bbp_theme_before_topic_author_admin_details' ); ?>
  • trunk/templates/default/bbpress/loop-single-reply.php

    r4733 r4783  
    4545        <?php bbp_reply_author_link( array( 'sep' => '<br />', 'show_role' => true ) ); ?>
    4646
    47         <?php if ( is_super_admin() ) : ?>
     47        <?php if ( bbp_is_user_keymaster() ) : ?>
    4848
    4949            <?php do_action( 'bbp_theme_before_reply_author_admin_details' ); ?>
Note: See TracChangeset for help on using the changeset viewer.