Changeset 4705

Timestamp:

01/22/2013 06:27:17 PM (14 years ago)

Author:

johnjamesjacoby

Message:

Audit form field functions. Cast some $_POST values. Props Maty.

File:

• trunk/includes/topics/template-tags.php (modified) (6 diffs)

trunk/includes/topics/template-tags.php

@@ -3495 +3495 @@
                 // Get _POST data
                 if ( 'post' == strtolower( $_SERVER['REQUEST_METHOD'] ) && isset( $_POST['bbp_forum_id'] ) ) {
-                        $topic_forum = $_POST['bbp_forum_id'];
+                        $topic_forum = (int) $_POST['bbp_forum_id'];
 
                 // Get edit data
@@ -3506 +3506 @@
                 }
 
-                return apply_filters( 'bbp_get_form_topic_forum', esc_attr( $topic_forum ) );
+                return apply_filters( 'bbp_get_form_topic_forum', $topic_forum );
         }
 
@@ -3535 +3535 @@
                 // Get _POST data
                 if ( 'post' == strtolower( $_SERVER['REQUEST_METHOD'] ) && isset( $_POST['bbp_topic_subscription'] ) ) {
-                        $topic_subscribed = $_POST['bbp_topic_subscription'];
+                        $topic_subscribed = (bool) $_POST['bbp_topic_subscription'];
 
                 // Get edit data
@@ -3558 +3558 @@
                 // No data
                 } else {
-                        $topic_subscribed = 0;
+                        $topic_subscribed = false;
                 }
 
@@ -3590 +3590 @@
                 // Get _POST data
                 if ( 'post' == strtolower( $_SERVER['REQUEST_METHOD'] ) && isset( $_POST['bbp_log_topic_edit'] ) ) {
-                        $topic_revision = $_POST['bbp_log_topic_edit'];
+                        $topic_revision = (int) $_POST['bbp_log_topic_edit'];
 
                 // No data
@@ -3597 +3597 @@
                 }
 
-                return apply_filters( 'bbp_get_form_topic_log_edit', checked( $topic_revision, true, false ) );
+                // Get checked output
+                $checked = checked( $topic_revision, true, false );
+
+                return apply_filters( 'bbp_get_form_topic_log_edit', $checked, $topic_revision );
         }