Changeset 4674

Timestamp:

12/31/2012 02:44:33 PM (12 years ago)

Author:

johnjamesjacoby

Message:

When spamming a topic, save the currently published replies in topic meta and trash them. This prevents rogue replies from appearing in user profiles and searches that have no live parent topic.

Also add similar logic to new reply handler, to add reply to topic meta if replying to a previously spammed topic. This is rare, as the ability is restricted to capable users, but must be done to keep meta synchronized.

Location:

trunk/includes

Files:

• replies/functions.php (modified) (1 diff)
• topics/functions.php (modified) (3 diffs)

trunk/includes/replies/functions.php

@@ -300 +300 @@
             // Update the pre_trashed_reply post meta
             update_post_meta( $topic_id, '_bbp_pre_trashed_replies', $pre_trashed_replies );
+
+        /** Spam Check ********************************************************/
+
+        // If reply or topic are spam, officially spam this reply
+        } elseif ( bbp_is_topic_spam( $topic_id ) || ( $reply_data['post_status'] == bbp_get_spam_status_id() ) ) {
+            add_post_meta( $reply_id, '_bbp_spam_meta_status', bbp_get_public_status_id() );
+
+            // Get pre_trashed_replies for topic
+            $pre_spammed_replies = get_post_meta( $topic_id, '_bbp_pre_spammed_replies', true );
+
+            // Add this reply to the end of the existing replies
+            $pre_spammed_replies[] = $reply_id;
+
+            // Update the pre_trashed_reply post meta
+            update_post_meta( $topic_id, '_bbp_pre_spammed_replies', $pre_spammed_replies );
         }
-
-        /** Spam Check ********************************************************/
-
-        // If reply or topic are spam, officially spam this reply
-        if ( bbp_is_topic_spam( $topic_id ) || ( $reply_data['post_status'] == bbp_get_spam_status_id() ) )
-            add_post_meta( $reply_id, '_bbp_spam_meta_status', bbp_get_public_status_id() );
 
         /** Update counts, etc... *********************************************/

trunk/includes/topics/functions.php

@@ -2691 +2691 @@
     do_action( 'bbp_spam_topic', $topic_id );
 
+    /** Trash Replies *********************************************************/
+
+    // Topic is being spammed, so its replies are trashed
+    $replies = new WP_Query( array(
+        'suppress_filters' => true,
+        'post_type'        => bbp_get_reply_post_type(),
+        'post_status'      => bbp_get_public_status_id(),
+        'post_parent'      => $topic_id,
+        'posts_per_page'   => -1,
+        'nopaging'         => true,
+        'fields'           => 'id=>parent'
+    ) );
+
+    if ( !empty( $replies->posts ) ) {
+
+        // Prevent debug notices
+        $pre_spammed_replies = array();
+
+        // Loop through replies, trash them, and add them to array
+        foreach ( $replies->posts as $reply ) {
+            wp_trash_post( $reply->ID );
+            $pre_spammed_replies[] = $reply->ID;
+        }
+
+        // Set a post_meta entry of the replies that were trashed by this action.
+        // This is so we can possibly untrash them, without untrashing replies
+        // that were purposefully trashed before.
+        update_post_meta( $topic_id, '_bbp_pre_spammed_replies', $pre_spammed_replies );
+
+        // Reset the $post global
+        wp_reset_postdata();
+    }
+
+    // Cleanup
+    unset( $replies );
+
+    /** Topic Tags ************************************************************/
+
     // Add the original post status as post meta for future restoration
     add_post_meta( $topic_id, '_bbp_spam_meta_status', $topic['post_status'] );
@@ -2762 +2800 @@
     do_action( 'bbp_unspam_topic', $topic_id );
 
+    /** Untrash Replies *******************************************************/
+
+    // Get the replies that were not previously trashed
+    $pre_spammed_replies = get_post_meta( $topic_id, '_bbp_pre_spammed_replies', true );
+
+    // There are replies to untrash
+    if ( !empty( $pre_spammed_replies ) ) {
+
+        // Maybe reverse the trashed replies array
+        if ( is_array( $pre_spammed_replies ) )
+            $pre_spammed_replies = array_reverse( $pre_spammed_replies );
+
+        // Loop through replies
+        foreach ( (array) $pre_spammed_replies as $reply ) {
+            wp_untrash_post( $reply );
+        }
+    }
+
+    /** Topic Tags ************************************************************/
+
+    // Get pre-spam topic tags
+    $terms = get_post_meta( $topic_id, '_bbp_spam_topic_tags', true );
+
+    // Topic had tags before it was spammed
+    if ( !empty( $terms ) ) {
+
+        // Set the tax_input of the topic
+        $topic['tax_input'] = array( bbp_get_topic_tag_tax_id() => $terms );
+
+        // Delete pre-spam topic tag meta
+        delete_post_meta( $topic_id, '_bbp_spam_topic_tags' );
+    }
+
+    /** Topic Status **********************************************************/
+
     // Get pre spam status
     $topic_status = get_post_meta( $topic_id, '_bbp_spam_meta_status', true );
@@ -2773 +2846 @@
     // No revisions
     remove_action( 'pre_post_update', 'wp_save_post_revision' );
-
-    // Get pre-spam topic tags
-    $terms = get_post_meta( $topic_id, '_bbp_spam_topic_tags', true );
-
-    // Topic had tags before it was spammed
-    if ( !empty( $terms ) ) {
-
-        // Set the tax_input of the topic
-        $topic['tax_input'] = array( bbp_get_topic_tag_tax_id() => $terms );
-
-        // Delete pre-spam topic tag meta
-        delete_post_meta( $topic_id, '_bbp_spam_topic_tags' );
-    }
 
     // Update the topic