Changeset 4611 for trunk/includes/topics/functions.php

Timestamp:

12/20/2012 04:08:55 PM (12 years ago)

Author:

johnjamesjacoby

Message:

Add some brackets to improve readability in /topics/functions.php. See #1799.

File:

• trunk/includes/topics/functions.php (modified) (8 diffs)

trunk/includes/topics/functions.php

@@ -2214 +2214 @@
 
     // If it's a reply, then get the parent (topic id)
-    if ( bbp_is_reply( $topic_id ) )
+    if ( bbp_is_reply( $topic_id ) ) {
         $topic_id = bbp_get_reply_topic_id( $topic_id );
-    else
+    } else {
         $topic_id = bbp_get_topic_id( $topic_id );
-
-    if ( empty( $forum_id ) )
+    }
+
+    if ( empty( $forum_id ) ) {
         $forum_id = get_post_field( 'post_parent', $topic_id );
+    }
 
     update_post_meta( $topic_id, '_bbp_forum_id', (int) $forum_id );
@@ -2266 +2268 @@
 
     // If it's a reply, then get the parent (topic id)
-    if ( bbp_is_reply( $topic_id ) )
+    if ( bbp_is_reply( $topic_id ) ) {
         $topic_id = bbp_get_reply_topic_id( $topic_id );
-    else
+    } else {
         $topic_id = bbp_get_topic_id( $topic_id );
+    }
 
     // Get replies of topic if not passed
-    if ( empty( $reply_count ) )
+    if ( empty( $reply_count ) ) {
         $reply_count = bbp_get_public_child_count( $topic_id, bbp_get_reply_post_type() );
+    }
 
     update_post_meta( $topic_id, '_bbp_reply_count', (int) $reply_count );
@@ -2302 +2306 @@
 
     // If it's a reply, then get the parent (topic id)
-    if ( bbp_is_reply( $topic_id ) )
+    if ( bbp_is_reply( $topic_id ) ) {
         $topic_id = bbp_get_reply_topic_id( $topic_id );
-    else
+    } else {
         $topic_id = bbp_get_topic_id( $topic_id );
+    }
 
     // Get replies of topic
-    if ( empty( $reply_count ) )
+    if ( empty( $reply_count ) ) {
         $reply_count = $wpdb->get_var( $wpdb->prepare( "SELECT COUNT(ID) FROM {$wpdb->posts} WHERE post_parent = %d AND post_status IN ( '" . join( '\',\'', array( bbp_get_trash_status_id(), bbp_get_spam_status_id() ) ) . "') AND post_type = '%s';", $topic_id, bbp_get_reply_post_type() ) );
+    }
 
     update_post_meta( $topic_id, '_bbp_reply_count_hidden', (int) $reply_count );
@@ -2337 +2343 @@
 
     // If it's a reply, then get the parent (topic id)
-    if ( bbp_is_reply( $topic_id ) )
+    if ( bbp_is_reply( $topic_id ) ) {
         $topic_id = bbp_get_reply_topic_id( $topic_id );
-    else
+    } else {
         $topic_id = bbp_get_topic_id( $topic_id );
-
-    if ( empty( $active_id ) )
+    }
+
+    if ( empty( $active_id ) ) {
         $active_id = bbp_get_public_child_last_id( $topic_id, bbp_get_reply_post_type() );
+    }
 
     // Adjust last_id's based on last_reply post_type
-    if ( empty( $active_id ) || !bbp_is_reply( $active_id ) )
+    if ( empty( $active_id ) || !bbp_is_reply( $active_id ) ) {
         $active_id = $topic_id;
+    }
 
     // Update only if published
-    if ( bbp_get_public_status_id() == get_post_status( $active_id ) )
+    if ( bbp_get_public_status_id() == get_post_status( $active_id ) ) {
         update_post_meta( $topic_id, '_bbp_last_active_id', (int) $active_id );
+    }
 
     return apply_filters( 'bbp_update_topic_last_active_id', (int) $active_id, $topic_id );
@@ -2372 +2382 @@
 
     // If it's a reply, then get the parent (topic id)
-    if ( bbp_is_reply( $topic_id ) )
+    if ( bbp_is_reply( $topic_id ) ) {
         $topic_id = bbp_get_reply_topic_id( $topic_id );
-    else
+    } else {
         $topic_id = bbp_get_topic_id( $topic_id );
+    }
 
     // Check time and use current if empty
-    if ( empty( $new_time ) )
+    if ( empty( $new_time ) ) {
         $new_time = get_post_field( 'post_date', bbp_get_public_child_last_id( $topic_id, bbp_get_reply_post_type() ) );
+    }
 
     // Update only if published
-    if ( !empty( $new_time ) )
+    if ( !empty( $new_time ) ) {
         update_post_meta( $topic_id, '_bbp_last_active_time', $new_time );
+    }
 
     return apply_filters( 'bbp_update_topic_last_active_time', $new_time, $topic_id );
@@ -2417 +2430 @@
     }
 
-    if ( empty( $reply_id ) )
+    if ( empty( $reply_id ) ) {
         $reply_id = bbp_get_public_child_last_id( $topic_id, bbp_get_reply_post_type() );
+    }
 
     // Adjust last_id's based on last_reply post_type
-    if ( empty( $reply_id ) || !bbp_is_reply( $reply_id ) )
+    if ( empty( $reply_id ) || !bbp_is_reply( $reply_id ) ) {
         $reply_id = 0;
+    }
 
     // Update if reply is published
-    if ( bbp_is_reply_published( $reply_id ) )
+    if ( bbp_is_reply_published( $reply_id ) ) {
         update_post_meta( $topic_id, '_bbp_last_reply_id', (int) $reply_id );
+    }
 
     return apply_filters( 'bbp_update_topic_last_reply_id', (int) $reply_id, $topic_id );
@@ -2454 +2470 @@
 
     // If it's a reply, then get the parent (topic id)
-    if ( bbp_is_reply( $topic_id ) )
+    if ( bbp_is_reply( $topic_id ) ) {
         $topic_id = bbp_get_reply_topic_id( $topic_id );
-    elseif ( bbp_is_topic( $topic_id ) )
+    } elseif ( bbp_is_topic( $topic_id ) ) {
         $topic_id = bbp_get_topic_id( $topic_id );
-    else
+    } else {
         return;
+    }
 
     // Query the DB to get voices in this topic
@@ -2496 +2513 @@
 
     // If it's a reply, then get the parent (topic id)
-    if ( bbp_is_reply( $topic_id ) )
+    if ( bbp_is_reply( $topic_id ) ) {
         $topic_id = bbp_get_reply_topic_id( $topic_id );
-    elseif ( bbp_is_topic( $topic_id ) )
+    } elseif ( bbp_is_topic( $topic_id ) ) {
         $topic_id = bbp_get_topic_id( $topic_id );
-    else
+    } else {
         return;
+    }
 
     $anonymous_replies = (int) $wpdb->get_var( $wpdb->prepare( "SELECT COUNT( ID ) FROM {$wpdb->posts} WHERE ( post_parent = %d AND post_status = '%s' AND post_type = '%s' AND post_author = 0 ) OR ( ID = %d AND post_type = '%s' AND post_author = 0 );", $topic_id, bbp_get_public_status_id(), bbp_get_reply_post_type(), $topic_id, bbp_get_topic_post_type() ) );