Changeset 4555

Timestamp:

12/07/2012 09:58:40 AM (12 years ago)

Author:

johnjamesjacoby

Message:

BuddyPress Groups:

• When enabling a group forum in an existing group, audit group forums, remove any strays, and maybe create a new forum if needed.
• Also fixes bugs in removing a value from group/forum ID arrays.
• Fixes #2083 (2.2 branch)

Location:

branches/2.2/includes/extend/buddypress

Files:

• functions.php (modified) (2 diffs)
• group.php (modified) (2 diffs)

branches/2.2/includes/extend/buddypress/functions.php

@@ -386 +386 @@
     // Maybe update the groups forums
     if ( in_array( $group_id, $group_ids ) ) {
-        unset( $group_ids[$group_id] );
+        $group_ids = array_diff( array_values( $group_ids ), (array) $group_id );
         return bbp_update_forum_group_ids( $forum_id, $group_ids );
     }
@@ -411 +411 @@
     // Maybe update the groups forums
     if ( in_array( $forum_id, $forum_ids ) ) {
-        unset( $forum_ids[$forum_id] );
+        $forum_ids = array_diff( array_values( $forum_ids ), (array) $forum_id );
         return bbp_update_group_forum_ids( $group_id, $forum_ids );
     }

branches/2.2/includes/extend/buddypress/group.php

@@ -275 +275 @@
         $forum_id     = 0;
         $group_id     = bp_get_current_group_id();
-        $forum_ids    = bbp_get_group_forum_ids( $group_id );
-        if ( !empty( $forum_ids ) )
-            $forum_id = (int) is_array( $forum_ids ) ? $forum_ids[0] : $forum_ids;
+        $forum_ids    = array_values( bbp_get_group_forum_ids( $group_id ) );
+
+        // Normalize group forum relationships now
+        if ( !empty( $forum_ids ) ) {
+
+            // Loop through forums, and make sure they exist
+            foreach ( $forum_ids as $forum_id ) {
+
+                // Look for forum
+                $forum = bbp_get_forum( $forum_id );
+
+                // No forum exists, so break the relationship
+                if ( empty( $forum ) ) {
+                    $this->remove_forum( array( 'forum_id' => $forum_id ) );
+                    unset( $forum_ids[$forum_id] );
+                }
+            }
+
+            // No support for multiple forums yet
+            $forum_id = (int) ( is_array( $forum_ids ) ? $forum_ids[0] : $forum_ids );
+        }
 
         // Update the group forum setting
@@ -283 +301 @@
         $group->enable_forum = $edit_forum;
         $group->save();
+
+        // Create a new forum
+        if ( empty( $forum_id ) && ( true === $edit_forum ) ) {
+
+            // Set the default forum status
+            switch ( $group->status ) {
+                case 'hidden'  :
+                    $status = bbp_get_hidden_status_id();
+                    break;
+                case 'private' :
+                    $status = bbp_get_private_status_id();
+                    break;
+                case 'public'  :
+                default        :
+                    $status = bbp_get_public_status_id();
+                    break;
+            }
+
+            // Create the initial forum
+            $forum_id = bbp_insert_forum( array(
+                'post_parent'  => bbp_get_group_forums_root_id(),
+                'post_title'   => $group->name,
+                'post_content' => $group->description,
+                'post_status'  => $status
+            ) );
+
+            // Run the BP-specific functions for new groups
+            $this->new_forum( array( 'forum_id' => $forum_id ) );
+        }
 
         // Redirect after save