Changeset 4496 for trunk/includes/common/template-tags.php

Timestamp:

11/24/2012 06:06:59 PM (14 years ago)

Author:

johnjamesjacoby

Message:

Clean-up bbp_get_dropdown() so unsetting variables for get_posts() usage is not necessary.

File:

• trunk/includes/common/template-tags.php (modified) (2 diffs)

trunk/includes/common/template-tags.php

@@ -1278 +1278 @@
                 }
 
-                // Unset the args not needed for WP_Query to avoid any possible conflicts.
-                // Note: walker and disable_categories are not unset
-                unset( $r['select_id'], $r['tab'], $r['options_only'], $r['show_none'], $r['none_found'] );
-
                 /** Post Status *******************************************************/
 
@@ -1313 +1309 @@
                 $tab       = (int) $r['tab'];
                 $retval    = '';
-                $posts     = get_posts( $r );
                 $disabled  = disabled( isset( bbpress()->options[$r['disabled']] ), true, false );
+                $posts     = get_posts( array(
+                        'post_type'   => $r['post_type'],
+                        'post_status' => $r['post_status'],
+                        'sort_column' => $r['sort_column'],
+                        'child_of'    => $r['child_of'],
+                        'numberposts' => $r['numberposts'],
+                        'orderby'     => $r['orderby'],
+                        'order'       => $r['order'],
+                ) );
 
                 /** Drop Down *********************************************************/