Changeset 4486

Timestamp:

11/23/2012 11:16:51 PM (13 years ago)

Author:

johnjamesjacoby

Message:

Extract:

• Remove extract() from bbp_update_reply_revision_log().
• Other general code cleanup.
• See #2056.

File:

• trunk/includes/replies/functions.php (modified) (1 diff)

trunk/includes/replies/functions.php

@@ -987 +987 @@
  */
 function bbp_update_reply_revision_log( $args = '' ) {
-    $defaults = array (
+
+    // Parse arguments with default values
+    $r = bbp_parse_args( $args, array(
         'reason'      => '',
         'reply_id'    => 0,
         'author_id'   => 0,
         'revision_id' => 0
-    );
-
-    $r = bbp_parse_args( $args, $defaults, 'update_reply_revision_log' );
-    extract( $r );
+    ), 'update_reply_revision_log' );
 
     // Populate the variables
-    $reason      = bbp_format_revision_reason( $reason );
-    $reply_id    = bbp_get_reply_id( $reply_id );
-    $author_id   = bbp_get_user_id ( $author_id, false, true );
-    $revision_id = (int) $revision_id;
+    $r['reason']      = bbp_format_revision_reason( $r['reason'] );
+    $r['reply_id']    = bbp_get_reply_id( $r['reply_id'] );
+    $r['author_id']   = bbp_get_user_id ( $r['author_id'], false, true );
+    $r['revision_id'] = (int) $r['revision_id'];
 
     // Get the logs and append the new one to those
-    $revision_log               = bbp_get_reply_raw_revision_log( $reply_id );
-    $revision_log[$revision_id] = array( 'author' => $author_id, 'reason' => $reason );
+    $revision_log                      = bbp_get_reply_raw_revision_log( $r['reply_id'] );
+    $revision_log[ $r['revision_id'] ] = array( 'author' => $r['author_id'], 'reason' => $r['reason'] );
 
     // Finally, update
-    update_post_meta( $reply_id, '_bbp_revision_log', $revision_log );
-
-    return apply_filters( 'bbp_update_reply_revision_log', $revision_log, $reply_id );
+    update_post_meta( $r['reply_id'], '_bbp_revision_log', $revision_log );
+
+    return apply_filters( 'bbp_update_reply_revision_log', $revision_log, $r['reply_id'] );
 }