Changeset 4480 for trunk/includes/admin/metaboxes.php

Timestamp:

11/23/2012 10:50:13 PM (13 years ago)

Author:

johnjamesjacoby

Message:

Extract:

• Remove extract() calls from some statistics functions.
• See #2056.

File:

• trunk/includes/admin/metaboxes.php (modified) (9 diffs)

trunk/includes/admin/metaboxes.php

@@ -36 +36 @@
 
     // Get the statistics and extract them
-    extract( bbp_get_statistics(), EXTR_SKIP ); ?>
+    $r = bbp_get_statistics(); ?>
 
     <div class="table table_content">
@@ -47 +47 @@
 
                 <?php
-                    $num  = $forum_count;
-                    $text = _n( 'Forum', 'Forums', $forum_count, 'bbpress' );
+                    $num  = $r['forum_count'];
+                    $text = _n( 'Forum', 'Forums', $r['forum_count'], 'bbpress' );
                     if ( current_user_can( 'publish_forums' ) ) {
                         $link = add_query_arg( array( 'post_type' => bbp_get_forum_post_type() ), get_admin_url( null, 'edit.php' ) );
@@ -64 +64 @@
 
                 <?php
-                    $num  = $topic_count;
-                    $text = _n( 'Topic', 'Topics', $topic_count, 'bbpress' );
+                    $num  = $r['topic_count'];
+                    $text = _n( 'Topic', 'Topics', $r['topic_count'], 'bbpress' );
                     if ( current_user_can( 'publish_topics' ) ) {
                         $link = add_query_arg( array( 'post_type' => bbp_get_topic_post_type() ), get_admin_url( null, 'edit.php' ) );
@@ -81 +81 @@
 
                 <?php
-                    $num  = $reply_count;
-                    $text = _n( 'Reply', 'Replies', $reply_count, 'bbpress' );
+                    $num  = $r['reply_count'];
+                    $text = _n( 'Reply', 'Replies', $r['reply_count'], 'bbpress' );
                     if ( current_user_can( 'publish_replies' ) ) {
                         $link = add_query_arg( array( 'post_type' => bbp_get_reply_post_type() ), get_admin_url( null, 'edit.php' ) );
@@ -100 +100 @@
 
                     <?php
-                        $num  = $topic_tag_count;
-                        $text = _n( 'Topic Tag', 'Topic Tags', $topic_tag_count, 'bbpress' );
+                        $num  = $r['topic_tag_count'];
+                        $text = _n( 'Topic Tag', 'Topic Tags', $r['topic_tag_count'], 'bbpress' );
                         if ( current_user_can( 'manage_topic_tags' ) ) {
                             $link = add_query_arg( array( 'taxonomy' => bbp_get_topic_tag_tax_id(), 'post_type' => bbp_get_topic_post_type() ), get_admin_url( null, 'edit-tags.php' ) );
@@ -132 +132 @@
 
                 <?php
-                    $num  = $user_count;
-                    $text = _n( 'User', 'Users', $user_count, 'bbpress' );
+                    $num  = $r['user_count'];
+                    $text = _n( 'User', 'Users', $r['user_count'], 'bbpress' );
                     if ( current_user_can( 'edit_users' ) ) {
                         $link = get_admin_url( null, 'users.php' );
@@ -146 +146 @@
             </tr>
 
-            <?php if ( isset( $topic_count_hidden ) ) : ?>
+            <?php if ( isset( $r['topic_count_hidden'] ) ) : ?>
 
                 <tr>
 
                     <?php
-                        $num  = $topic_count_hidden;
-                        $text = _n( 'Hidden Topic', 'Hidden Topics', $topic_count_hidden, 'bbpress' );
+                        $num  = $r['topic_count_hidden'];
+                        $text = _n( 'Hidden Topic', 'Hidden Topics', $r['topic_count_hidden'], 'bbpress' );
                         $link = add_query_arg( array( 'post_type' => bbp_get_topic_post_type() ), get_admin_url( null, 'edit.php' ) );
                         if ( '0' != $num ) {
                             $link = add_query_arg( array( 'post_status' => bbp_get_spam_status_id() ), $link );
                         }
-                        $num  = '<a href="' . $link . '" title="' . esc_attr( $hidden_topic_title ) . '">' . $num  . '</a>';
-                        $text = '<a class="waiting" href="' . $link . '" title="' . esc_attr( $hidden_topic_title ) . '">' . $text . '</a>';
+                        $num  = '<a href="' . $link . '" title="' . esc_attr( $r['hidden_topic_title'] ) . '">' . $num  . '</a>';
+                        $text = '<a class="waiting" href="' . $link . '" title="' . esc_attr( $r['hidden_topic_title'] ) . '">' . $text . '</a>';
                     ?>
 
@@ -168 +168 @@
             <?php endif; ?>
 
-            <?php if ( isset( $reply_count_hidden ) ) : ?>
+            <?php if ( isset( $r['reply_count_hidden'] ) ) : ?>
 
                 <tr>
 
                     <?php
-                        $num  = $reply_count_hidden;
-                        $text = _n( 'Hidden Reply', 'Hidden Replies', $reply_count_hidden, 'bbpress' );
+                        $num  = $r['reply_count_hidden'];
+                        $text = _n( 'Hidden Reply', 'Hidden Replies', $r['reply_count_hidden'], 'bbpress' );
                         $link = add_query_arg( array( 'post_type' => bbp_get_reply_post_type() ), get_admin_url( null, 'edit.php' ) );
                         if ( '0' != $num ) {
                             $link = add_query_arg( array( 'post_status' => bbp_get_spam_status_id() ), $link );
                         }
-                        $num  = '<a href="' . $link . '" title="' . esc_attr( $hidden_reply_title ) . '">' . $num  . '</a>';
-                        $text = '<a class="waiting" href="' . $link . '" title="' . esc_attr( $hidden_reply_title ) . '">' . $text . '</a>';
+                        $num  = '<a href="' . $link . '" title="' . esc_attr( $r['hidden_reply_title'] ) . '">' . $num  . '</a>';
+                        $text = '<a class="waiting" href="' . $link . '" title="' . esc_attr( $r['hidden_reply_title'] ) . '">' . $text . '</a>';
                     ?>
 
@@ -190 +190 @@
             <?php endif; ?>
 
-            <?php if ( bbp_allow_topic_tags() && isset( $empty_topic_tag_count ) ) : ?>
+            <?php if ( bbp_allow_topic_tags() && isset( $r['empty_topic_tag_count'] ) ) : ?>
 
                 <tr>
 
                     <?php
-                        $num  = $empty_topic_tag_count;
-                        $text = _n( 'Empty Topic Tag', 'Empty Topic Tags', $empty_topic_tag_count, 'bbpress' );
+                        $num  = $r['empty_topic_tag_count'];
+                        $text = _n( 'Empty Topic Tag', 'Empty Topic Tags', $r['empty_topic_tag_count'], 'bbpress' );
                         $link = add_query_arg( array( 'taxonomy' => bbp_get_topic_tag_tax_id(), 'post_type' => bbp_get_topic_post_type() ), get_admin_url( null, 'edit-tags.php' ) );
                         $num  = '<a href="' . $link . '">' . $num  . '</a>';