Changeset 4345

Timestamp:

11/06/2012 12:22:23 AM (14 years ago)

Author:

johnjamesjacoby

Message:

Tools:

• Remove empty( $users ) check in bbp_admin_repair_user_roles().
• Handled by while() loop.
• Tweak inline doc in bbp_admin_repair_user_roles().

File:

• trunk/includes/admin/tools.php (modified) (3 diffs)

trunk/includes/admin/tools.php

@@ -599 +599 @@
                 $offset = 0;
 
-                // Get users of 
+                // Get users of this site, limited to 1000
                 while ( $users = get_users( array(
                                 'role'   => $role,
@@ -607 +607 @@
                         ) ) ) {
 
-                        // Keep iterating if no users exist for this role
-                        if ( empty( $users ) )
-                                continue;
-
                         // Iterate through each user of $role and try to set it
-                        foreach ( $users as $user_id ) {
+                        foreach ( (array) $users as $user_id ) {
                                 if ( bbp_set_user_role( $user_id, $role_map[$role] ) ) {
                                         ++$changed; // Keep a count to display at the end
@@ -618 +614 @@
                         }
 
-                        // Bump the offset
+                        // Bump the offset for the next query iteration
                         $offset = $offset + 1000;
                 }