Changeset 4331 for trunk/includes/forums/template-tags.php

Timestamp:

11/04/2012 04:22:18 AM (13 years ago)

Author:

johnjamesjacoby

Message:

Code Improvement:

• Revert part of r4258.
• Cast as int instead of using absint()
• Fixes regression that broke existing bbPress plugin (hierarchical replies.)
• Fixes #2008.

File:

• trunk/includes/forums/template-tags.php (modified) (5 diffs)

trunk/includes/forums/template-tags.php

@@ -1177 +1177 @@
     function bbp_get_forum_subforum_count( $forum_id = 0, $integer = false ) {
         $forum_id    = bbp_get_forum_id( $forum_id );
-        $forum_count = absint( get_post_meta( $forum_id, '_bbp_forum_subforum_count', true ) );
+        $forum_count = (int) get_post_meta( $forum_id, '_bbp_forum_subforum_count', true );
         $filter      = ( true === $integer ) ? 'bbp_get_forum_subforum_count_int' : 'bbp_get_forum_subforum_count';
 
@@ -1214 +1214 @@
         $forum_id = bbp_get_forum_id( $forum_id );
         $meta_key = empty( $total_count ) ? '_bbp_topic_count' : '_bbp_total_topic_count';
-        $topics   = absint( get_post_meta( $forum_id, $meta_key, true ) );
+        $topics   = (int) get_post_meta( $forum_id, $meta_key, true );
         $filter   = ( true === $integer ) ? 'bbp_get_forum_topic_count_int' : 'bbp_get_forum_topic_count';
 
@@ -1251 +1251 @@
         $forum_id = bbp_get_forum_id( $forum_id );
         $meta_key = empty( $total_count ) ? '_bbp_reply_count' : '_bbp_total_reply_count';
-        $replies  = absint( get_post_meta( $forum_id, $meta_key, true ) );
+        $replies  = (int) get_post_meta( $forum_id, $meta_key, true );
         $filter   = ( true === $integer ) ? 'bbp_get_forum_reply_count_int' : 'bbp_get_forum_reply_count';
 
@@ -1289 +1289 @@
         $topics   = bbp_get_forum_topic_count( $forum_id, $total_count, true );
         $meta_key = empty( $total_count ) ? '_bbp_reply_count' : '_bbp_total_reply_count';
-        $replies  = absint( get_post_meta( $forum_id, $meta_key, true ) );
+        $replies  = (int) get_post_meta( $forum_id, $meta_key, true );
         $retval   = $replies + $topics;
         $filter   = ( true === $integer ) ? 'bbp_get_forum_post_count_int' : 'bbp_get_forum_post_count';
@@ -1325 +1325 @@
     function bbp_get_forum_topic_count_hidden( $forum_id = 0, $integer = false ) {
         $forum_id = bbp_get_forum_id( $forum_id );
-        $topics   = absint( get_post_meta( $forum_id, '_bbp_topic_count_hidden', true ) );
+        $topics   = (int) get_post_meta( $forum_id, '_bbp_topic_count_hidden', true );
         $filter   = ( true === $integer ) ? 'bbp_get_forum_topic_count_hidden_int' : 'bbp_get_forum_topic_count_hidden';