Changeset 4259

Timestamp:

10/19/2012 08:11:39 AM (12 years ago)

Author:

johnjamesjacoby

Message:

Dropdowns:

• Revert back to text inputs for topic and forum ID's in metaboxes.
• Fixes memory issues when loading thousands of posts.
• Fixes #1878.
• See #1901.

File:

• trunk/bbp-includes/admin/metaboxes.php (modified) (9 diffs)

trunk/bbp-includes/admin/metaboxes.php

@@ -299 +299 @@
         <strong class="label"><?php _e( 'Parent:', 'bbpress' ); ?></strong>
         <label class="screen-reader-text" for="parent_id"><?php _e( 'Forum Parent', 'bbpress' ); ?></label>
-
-        <?php
-            bbp_dropdown( array(
-                'exclude'            => $post_id,
-                'selected'           => $post_parent,
-                'show_none'          => __( '(No Parent)', 'bbpress' ),
-                'select_id'          => 'parent_id',
-                'disable_categories' => false
-            ) );
-        ?>
-
+        <input name="parent_id" id="parent_id" type="number" step="1" value="<?php echo esc_attr( $post_parent ); ?>" />
     </p>
 
@@ -315 +305 @@
         <strong class="label"><?php _e( 'Order:', 'bbpress' ); ?></strong>
         <label class="screen-reader-text" for="menu_order"><?php _e( 'Forum Order', 'bbpress' ); ?></label>
-        <input name="menu_order" type="text" size="4" id="menu_order" value="<?php echo $menu_order; ?>" />
+        <input name="menu_order" type="number" step="1" size="4" id="menu_order" value="<?php echo esc_attr( $menu_order ); ?>" />
     </p>
 
@@ -333 +323 @@
  *
  * @uses bbp_get_topic_forum_id() To get the topic forum id
- * @uses bbp_dropdown() To show a dropdown of the forums for topic parent
  * @uses do_action() Calls 'bbp_topic_metabox'
  */
@@ -339 +328 @@
 
     // Post ID
-    $post_id = get_the_ID();
-
-    $args = array(
-        'selected'  => bbp_get_topic_forum_id( $post_id ),
-        'select_id' => 'parent_id',
-        'show_none' => is_super_admin() ? __( '(No Forum)', 'bbpress' ) : '',
-    ); ?>
-
-    <p><strong><?php _e( 'Forum', 'bbpress' ); ?></strong></p>
-
-    <p>
-        <label class="screen-reader-text" for="parent_id"><?php _e( 'Forum', 'bbpress' ); ?></label>
-        <?php bbp_dropdown( $args ); ?>
-    </p>
+    $post_id = get_the_ID(); ?>
 
     <p><strong><?php _e( 'Topic Type', 'bbpress' ); ?></strong></p>
@@ -359 +335 @@
         <label class="screen-reader-text" for="bbp_stick_topic"><?php _e( 'Topic Type', 'bbpress' ); ?></label>
         <?php bbp_topic_type_select( array( 'topic_id' => $post_id ) ); ?>
+    </p>
+
+    <p><strong><?php _e( 'Forum', 'bbpress' ); ?></strong></p>
+
+    <p>
+        <label class="screen-reader-text" for="parent_id"><?php _e( 'Forum', 'bbpress' ); ?></label>
+        <input name="parent_id" id="parent_id" type="number" step="1" value="<?php bbp_topic_forum_id( $post_id ); ?>" />
     </p>
 
@@ -376 +359 @@
  *
  * @uses bbp_get_topic_post_type() To get the topic post type
- * @uses bbp_dropdown() To show a dropdown of the topics for reply parent
  * @uses do_action() Calls 'bbp_reply_metabox'
  */
@@ -389 +371 @@
 
     // Allow individual manipulation of reply forum
-    if ( current_user_can( 'edit_others_replies' ) || current_user_can( 'moderate' ) ) :
-
-        // Forums
-        $args = array(
-            'selected'  => $reply_forum_id,
-            'select_id' => 'bbp_forum_id',
-            'show_none' => __( '(Use Forum of Topic)', 'bbpress' )
-        ); ?>
+    if ( current_user_can( 'edit_others_replies' ) || current_user_can( 'moderate' ) ) : ?>
 
         <p><strong><?php _e( 'Forum', 'bbpress' ); ?></strong></p>
@@ -402 +377 @@
         <p>
             <label class="screen-reader-text" for="bbp_forum_id"><?php _e( 'Forum', 'bbpress' ); ?></label>
-
-            <?php bbp_dropdown( $args ); ?>
-
+            <input name="bbp_forum_id" id="bbp_forum_id" type="number" step="1" value="<?php echo esc_attr( $reply_forum_id ); ?>" />
         </p>
 
-    <?php endif;
-
-    // Topics
-    $args = array(
-        'post_type'   => bbp_get_topic_post_type(),
-        'selected'    => $reply_topic_id,
-        'select_id'   => 'parent_id',
-        'orderby'     => 'post_date',
-        'numberposts' => '250',
-        'show_none'   => is_super_admin() ? __( '(No Topic)', 'bbpress' ) : '',
-    );
-
-    // Allow the dropdown to be filtered, to extend or limit the available
-    // topics to choose as the reply parent.
-    $args = apply_filters( 'bbp_reply_parent_dropdown', $args ); ?>
+    <?php endif; ?>
 
     <p><strong><?php _e( 'Topic', 'bbpress' ); ?></strong></p>
@@ -427 +386 @@
     <p>
         <label class="screen-reader-text" for="parent_id"><?php _e( 'Topic', 'bbpress' ); ?></label>
-
-        <?php bbp_dropdown( $args ); ?>
-
+        <input name="parent_id" id="parent_id" type="number" step="1" value="<?php echo esc_attr( $reply_topic_id ); ?>" />
     </p>