Changeset 4001 for branches/plugin/bbp-admin/converters/bbPress1.php

Timestamp:

06/23/2012 12:39:50 AM (14 years ago)

Author:

johnjamesjacoby

Message:

bbPress 1.1 Converter:

• Test removing post_position = 1 check from topics, which is preventing spam/trashed topics from being converted.
• Add reply position to replies.
• Inline doc clean-up.

File:

• branches/plugin/bbp-admin/converters/bbPress1.php (modified) (9 diffs)

branches/plugin/bbp-admin/converters/bbPress1.php

@@ -2 +2 @@
 
 /**
- * Implementation of bbPress Stand Alone converter.
+ * bbPress 1.1 Converter
+ *
+ * @since bbPress (rxxxx)
  */
 class bbPress1 extends BBP_Converter_Base {
@@ -12 +14 @@
         public function setup_globals() {
 
-                /** Forum Section ******************************************************/
+                /** Forum Section *****************************************************/
 
                 // Forum id. Stored in postmeta.
@@ -118 +120 @@
                 );
 
-                /** Topic Section ******************************************************/
+                /** Topic Section *****************************************************/
 
                 // Topic id. Stored in postmeta.
@@ -178 +180 @@
                         'join_tablename'  => 'topics',
                         'join_type'       => 'INNER',
-                        'join_expression' => 'USING (topic_id) WHERE posts.post_position = 1',
+                        //'join_expression' => 'USING (topic_id) WHERE posts.post_position = 1',
+                        'join_expression' => 'USING (topic_id)',
                         'to_type'         => 'topic',
                         'to_fieldname'    => 'post_content',
@@ -185 +188 @@
 
                 // Topic status.
+                // Note: post_status is more accurate than topic_status
                 $this->field_map[] = array(
                         'from_tablename'  => 'posts',
@@ -190 +194 @@
                         'join_tablename'  => 'topics',
                         'join_type'       => 'INNER',
-                        'join_expression' => 'USING (topic_id) WHERE posts.post_position = 1',
+                        //'join_expression' => 'USING (topic_id) WHERE posts.post_position = 1',
+                        'join_expression' => 'USING (topic_id)',
                         'to_type'         => 'topic',
                         'to_fieldname'    => 'post_status',
@@ -298 +303 @@
                 );
 
-                // Topic content.
+                // Topic title.
                 $this->field_map[] = array(
                         'from_tablename'  => 'topics',
@@ -336 +341 @@
                 );
 
-                // Post content.
+                // Reply content.
                 $this->field_map[] = array(
                         'from_tablename'  => 'posts',
@@ -343 +348 @@
                         'to_fieldname'    => 'post_content',
                         'callback_method' => 'callback_html'
+                );
+
+                // Reply content.
+                $this->field_map[] = array(
+                        'from_tablename'  => 'posts',
+                        'from_fieldname'  => 'post_position',
+                        'to_type'         => 'reply',
+                        'to_fieldname'    => 'menu_order'
                 );