Changeset 3912

Timestamp:

05/22/2012 08:28:28 AM (13 years ago)

Author:

johnjamesjacoby

Message:

Redirects:

• Tweak topic and reply form fields to include redirect_to field.
• Fix redirect logic in single items after editing.
• Remove forum_id from new reply hidden fields, and calculate on handler based off of topic ID (to prevent mismatches.)
• Fixes #1829.

Location:

branches/plugin/bbp-includes

Files:

• bbp-common-template.php (modified) (5 diffs)
• bbp-reply-functions.php (modified) (1 diff)

branches/plugin/bbp-includes/bbp-common-template.php

@@ -1170 +1170 @@
         <input type="hidden" name="bbp_forum_id" id="bbp_forum_id"    value="<?php bbp_forum_id(); ?>" />
 
+        <?php bbp_redirect_to_field( bbp_get_forum_permalink( bbp_get_forum_id() ) ); ?>
+
         <?php
 
@@ -1219 +1221 @@
         <input type="hidden" name="bbp_topic_id" id="bbp_topic_id"    value="<?php bbp_topic_id(); ?>" />
 
+        <?php bbp_redirect_to_field( bbp_get_topic_permalink( bbp_get_topic_id() ) ); ?>
+
         <?php
 
@@ -1233 +1237 @@
 
             <input type="hidden" name="bbp_forum_id" id="bbp_forum_id" value="<?php bbp_forum_id(); ?>" />
-
-            <?php bbp_redirect_to_field( get_permalink() ); ?>
 
         <?php endif; ?>
@@ -1267 +1269 @@
         <input type="hidden" name="action"          id="bbp_post_action" value="bbp-edit-reply" />
 
+        <?php bbp_redirect_to_field( bbp_get_reply_url( bbp_get_reply_id() ) ); ?>
+
         <?php if ( current_user_can( 'unfiltered_html' ) )
             wp_nonce_field( 'bbp-unfiltered-html-reply_' . bbp_get_reply_id(), '_bbp_unfiltered_html_reply', false ); ?>
@@ -1275 +1279 @@
 
         <input type="hidden" name="bbp_reply_title" id="bbp_reply_title" value="<?php printf( __( 'Reply To: %s', 'bbpress' ), bbp_get_topic_title() ); ?>" maxlength="<?php bbp_get_title_max_length(); ?>" />
-        <input type="hidden" name="bbp_forum_id"    id="bbp_forum_id"    value="<?php bbp_forum_id(); ?>" />
         <input type="hidden" name="bbp_topic_id"    id="bbp_topic_id"    value="<?php bbp_topic_id(); ?>" />
         <input type="hidden" name="action"          id="bbp_post_action" value="bbp-new-reply" />

branches/plugin/bbp-includes/bbp-reply-functions.php

@@ -160 +160 @@
     if ( isset( $_POST['bbp_forum_id'] ) ) {
         $forum_id = (int) $_POST['bbp_forum_id'];
+    } elseif ( !empty( $topic_id ) ) {
+        $forum_id = bbp_get_topic_forum_id( $topic_id );
     } else {
         bbp_add_error( 'bbp_reply_forum_id', __( '<strong>ERROR</strong>: Forum ID is missing.', 'bbpress' ) );