Changeset 3910

Timestamp:

05/21/2012 07:50:04 PM (13 years ago)

Author:

johnjamesjacoby

Message:

Use get_users() in bbp_get_total_users() to avoid a direct database query. See #1826. Props tott.

File:

• branches/plugin/bbp-includes/bbp-user-functions.php (modified) (3 diffs)

branches/plugin/bbp-includes/bbp-user-functions.php

@@ -1054 +1054 @@
  *
  * @since bbPress (r2769)
- *
  * @uses wp_cache_get() Check if query is in cache
- * @uses wpdb::get_var() To execute our query and get the var back
+ * @uses get_users() To execute our query and get the var back
  * @uses wp_cache_set() Set the query in the cache
  * @uses apply_filters() Calls 'bbp_get_total_users' with number of users
@@ -1062 +1061 @@
  */
 function bbp_get_total_users() {
-    global $wpdb;
 
     $bbp_total_users = wp_cache_get( 'bbp_total_users', 'bbpress' );
@@ -1068 +1066 @@
         return $bbp_total_users;
 
-    $bbp_total_users = $wpdb->get_var( "SELECT COUNT(ID) FROM {$wpdb->users} USE INDEX (PRIMARY);" );
+    $bbp_total_users = count( get_users() );
 
     wp_cache_set( 'bbp_total_users', $bbp_total_users, 'bbpress' );
 
-    return apply_filters( 'bbp_get_total_users', (int) $bbp_total_users );
+    return (int) apply_filters( 'bbp_get_total_users', (int) $bbp_total_users );
 }