Changeset 3893 for branches/plugin/bbp-admin/bbp-converter.php

Timestamp:

05/07/2012 04:32:55 AM (14 years ago)

Author:

johnjamesjacoby

Message:

Converter:

• Remove commented cruft from bbPress 1.x converter
• Improvements to ajax and spinner
• See #1820

File:

• branches/plugin/bbp-admin/bbp-converter.php (modified) (5 diffs)

branches/plugin/bbp-admin/bbp-converter.php

@@ -190 +190 @@
 
             function bbconverter_start() {
-                if( !bbconverter_is_running ) {
+                if( false == bbconverter_is_running ) {
                     bbconverter_is_running = true;
                     jQuery('#bbp-converter-start').hide();
@@ -214 +214 @@
             function bbconverter_stop() {
                 bbconverter_is_running = false;
+                jQuery('#bbp-converter-message strong').removeClass( 'loading' );
             }
 
@@ -224 +225 @@
                     jQuery('#bbp-converter-stop').hide();
                     jQuery('#bbp-converter-progress').hide();
+                    bbconverter_stop();
                     clearTimeout( bbconverter_run_timer );
                 } else if( bbconverter_is_running ) { // keep going
@@ -238 +240 @@
 
             function bbconverter_log(text) {
-                if(jQuery('#bbp-converter-message').css('display') == 'none') {
+                if ( jQuery('#bbp-converter-message').css('display') == 'none' ) {
                     jQuery('#bbp-converter-message').show();
                 }
-                if( text ) {
+                if ( text ) {
                     jQuery('#bbp-converter-message strong').removeClass( 'loading' );
                     jQuery('#bbp-converter-message').prepend('<p><strong class="loading">' + text + '</strong></p>');
@@ -578 +580 @@
     public $sync_table_name;
 
+    /** Methods ***************************************************************/
+
     /**
      * This is the constructor and it connects to the platform databases.
      */
-    function __construct() {
+    public function __construct() {
         $this->setup_globals();
     }