Changeset 3854 for branches/1.1/bb-includes/functions.bb-topic-tags.php

Timestamp:

04/21/2012 12:48:54 AM (14 years ago)

Author:

nacin

Message:

In bb_create_tag(), avoid calling list() on the insert_term() method of the taxonomy object, as this method may return WP_Error.

Calling list() on a WP_Error object would result in a fatal error. Instead, check for WP_Error before breaking up the return value.

props otto42. for bbPress 1.1.

File:

• branches/1.1/bb-includes/functions.bb-topic-tags.php (modified) (1 diff)

branches/1.1/bb-includes/functions.bb-topic-tags.php

@@ -66 +66 @@
         return $tt_id;
 
-    list($term_id, $tt_id) = $wp_taxonomy_object->insert_term( $tag, 'bb_topic_tag' );
-
-    if ( is_wp_error($term_id) || is_wp_error($tt_id) || !$tt_id )
+    $term = $wp_taxonomy_object->insert_term( $tag, 'bb_topic_tag' );
+    if ( is_wp_error( $term ) )
+        return false;
+
+    list( $term_id, $tt_id ) = $term;
+    if ( ! $tt_id )
         return false;