Changeset 3805 for branches/plugin/bbp-includes/bbp-reply-template.php

Timestamp:

03/16/2012 05:26:49 AM (14 years ago)

Author:

johnjamesjacoby

Message:

Add missing filters to some topic template tags.

• Remove inline logic from within some apply_filters() calls
• Props MZAWeb for initial patch
• Fixes #1787

File:

• branches/plugin/bbp-includes/bbp-reply-template.php (modified) (6 diffs)

branches/plugin/bbp-includes/bbp-reply-template.php

@@ -718 +718 @@
  */
 function bbp_is_reply_published( $reply_id = 0 ) {
-    $reply_status = bbp_get_reply_status( bbp_get_reply_id( $reply_id ) );
-    return apply_filters( 'bbp_is_reply_published', bbp_get_public_status_id() == $reply_status, $reply_id );
+    $reply_status = bbp_get_reply_status( bbp_get_reply_id( $reply_id ) ) == bbp_get_public_status_id();
+    return (bool) apply_filters( 'bbp_is_reply_published', (bool) $reply_status, $reply_id );
 }
 
@@ -733 +733 @@
  */
 function bbp_is_reply_spam( $reply_id = 0 ) {
-    $reply_status = bbp_get_reply_status( bbp_get_reply_id( $reply_id ) );
-    return apply_filters( 'bbp_is_reply_spam', bbp_get_spam_status_id() == $reply_status, $reply_id );
+    $reply_status = bbp_get_reply_status( bbp_get_reply_id( $reply_id ) ) == bbp_get_spam_status_id();
+    return (bool) apply_filters( 'bbp_is_reply_spam', (bool) $reply_status, $reply_id );
 }
 
@@ -748 +748 @@
  */
 function bbp_is_reply_trash( $reply_id = 0 ) {
-    $reply_status = bbp_get_reply_status( bbp_get_reply_id( $reply_id ) );
-    return apply_filters( 'bbp_is_reply_trash', bbp_get_trash_status_id() == $reply_status, $reply_id );
+    $reply_status = bbp_get_reply_status( bbp_get_reply_id( $reply_id ) ) == bbp_get_trash_status_id();
+    return (bool) apply_filters( 'bbp_is_reply_trash', (bool) $reply_status, $reply_id );
 }
 
@@ -765 +765 @@
 function bbp_is_reply_anonymous( $reply_id = 0 ) {
     $reply_id = bbp_get_reply_id( $reply_id );
-
-    $retval = false;
+    $retval   = false;
 
     if ( !bbp_get_reply_author_id( $reply_id ) )
@@ -777 +776 @@
         $retval = true;
 
-    return apply_filters( 'bbp_is_reply_anonymous', $retval );
+    return (bool) apply_filters( 'bbp_is_reply_anonymous', $retval, $reply_id );
 }
 
@@ -844 +843 @@
         $author_id = get_post_field( 'post_author', $reply_id );
 
-        return apply_filters( 'bbp_get_reply_author_id', (int) $author_id, $reply_id );
+        return (int) apply_filters( 'bbp_get_reply_author_id', (int) $author_id, $reply_id );
     }