Changeset 3704 for branches/plugin/bbp-includes/bbp-common-template.php

Timestamp:

01/28/2012 08:41:37 AM (13 years ago)

Author:

johnjamesjacoby

Message:

Clean-up bbp-common-template.php:

• Remove unused globals
• Use bbp_get_global_post_field()
• Avoid accidental inline assignments

File:

• branches/plugin/bbp-includes/bbp-common-template.php (modified) (5 diffs)

branches/plugin/bbp-includes/bbp-common-template.php

@@ -479 +479 @@
  */
 function bbp_is_user_home() {
-    global $bbp;
 
     // Assume false
@@ -1075 +1074 @@
 
         // Forums
-        if ( $post_type == bbp_get_forum_post_type() ) {
+        if ( bbp_get_forum_post_type() == $post_type ) {
 
             // Private forums
-            if ( current_user_can( 'read_private_forums' ) )
+            if ( current_user_can( 'read_private_forums' ) ) {
                 $post_stati[] = bbp_get_private_status_id();
+            }
 
             // Hidden forums
-            if ( current_user_can( 'read_hidden_forums' ) )
+            if ( current_user_can( 'read_hidden_forums' ) ) {
                 $post_stati[] = bbp_get_hidden_status_id();
+            }
         }
 
@@ -1409 +1410 @@
             // If it's an edit, use the $post global
             if ( bbp_is_edit() ) {
-                global $post;
-                $post_content = $post->post_content;
+                $post_content = bbp_get_global_post_field( 'post_content' );
             }
 
@@ -1517 +1517 @@
         global $bbp;
 
-        if ( !$view = bbp_get_view_id( $view ) )
+        $view = bbp_get_view_id( $view );
+        if ( empty( $view ) )
             return false;
 
@@ -1550 +1551 @@
         global $bbp, $wp_rewrite;
 
-        if ( !$view = bbp_get_view_id( $view ) )
+        $view = bbp_get_view_id( $view );
+        if ( empty( $view ) )
             return home_url();