Changeset 3674 for branches/plugin/bbp-includes/bbp-reply-functions.php

Timestamp:

01/17/2012 06:55:18 PM (15 years ago)

Author:

johnjamesjacoby

Message:

Allow additional anonymous data to be automatically saved on reply and topic update any prevent any possible debug notices with missing core values in the process.

File:

• branches/plugin/bbp-includes/bbp-reply-functions.php (modified) (2 diffs)

branches/plugin/bbp-includes/bbp-reply-functions.php

@@ -401 +401 @@
 
                         // Filter anonymous data
-                        $anonymous_data = bbp_filter_anonymous_post_data( array(), true );
+                        $anonymous_data = bbp_filter_anonymous_post_data();
                 }
         }
@@ -617 +617 @@
         // Check bbp_filter_anonymous_post_data() for sanitization.
         if ( !empty( $anonymous_data ) && is_array( $anonymous_data ) ) {
-                extract( $anonymous_data );
-
-                update_post_meta( $reply_id, '_bbp_anonymous_name',  $bbp_anonymous_name,  false );
-                update_post_meta( $reply_id, '_bbp_anonymous_email', $bbp_anonymous_email, false );
+
+                // Always set at least these three values to empty
+                $defaults = array(
+                        'bbp_anonymous_name'    => '',
+                        'bbp_anonymous_email'   => '',
+                        'bbp_anonymous_website' => '',
+                );
+                $r = wp_parse_args( $anonymous_data, $defaults );
+
+                // Update all anonymous metas
+                foreach( $r as $anon_key => $anon_value ) {
+                        update_post_meta( $reply_id, '_' . $anon_key, (string) $anon_value, false );
+                }
 
                 // Set transient for throttle check (only on new, not edit)
                 if ( empty( $is_edit ) ) {
                         set_transient( '_bbp_' . bbp_current_author_ip() . '_last_posted', time() );
-                }
-
-                // Website is optional
-                if ( !empty( $bbp_anonymous_website ) ) {
-                        update_post_meta( $reply_id, '_bbp_anonymous_website', $bbp_anonymous_website, false );
                 }