Changeset 3571 for branches/plugin/bbp-includes/bbp-topic-template.php

Timestamp:

11/02/2011 06:21:14 PM (14 years ago)

Author:

johnjamesjacoby

Message:

Use get_post_class() to fix premature echo of forum/topic/reply post classes. See #1650, r3543. (2.1)

File:

• branches/plugin/bbp-includes/bbp-topic-template.php (modified) (2 diffs)

branches/plugin/bbp-includes/bbp-topic-template.php

@@ -1931 +1931 @@
      * @uses bbp_is_topic_super_sticky() To check if the topic is a super
      *                                    sticky
-     * @uses post_class() To get the topic classes
+     * @uses get_post_class() To get the topic classes
      * @uses apply_filters() Calls 'bbp_get_topic_class' with the classes
      *                        and topic id
@@ -1939 +1939 @@
         global $bbp;
 
+        $topic_id  = bbp_get_topic_id( $topic_id );
+        $count     = isset( $bbp->topic_query->current_post ) ? $bbp->topic_query->current_post : 1;
         $classes   = array();
-        $classes[] = $bbp->topic_query->current_post % 2     ? 'even'         : 'odd';
+        $classes[] = ( (int) $count % 2 )                    ? 'even'         : 'odd';
         $classes[] = bbp_is_topic_sticky( $topic_id, false ) ? 'sticky'       : '';
         $classes[] = bbp_is_topic_super_sticky( $topic_id  ) ? 'super-sticky' : '';
         $classes   = array_filter( $classes );
-        $post      = post_class( $classes, $topic_id );
-
-        return apply_filters( 'bbp_get_topic_class', $post, $topic_id );
+        $retval    = get_post_class( $classes, $topic_id );
+        $retval    = 'class="' . join( ' ', $retval ) . '"';
+
+        return apply_filters( 'bbp_get_topic_class', $retval, $topic_id );
     }